Skip to content

console: do not emit error events #9744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 3 commits into from
+117 −5
Closed

console: do not emit error events #9744

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
43e9611
console: do not emit error events
addaleax Nov 22, 2016
8851777
[squash] add more common.mustCalls
addaleax Feb 12, 2017
8b46d5e
[squash] use default value for ignoreErrors parameter
addaleax Feb 12, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
[squash] use default value for ignoreErrors parameter
  • Loading branch information
@addaleax
addaleax committed Feb 12, 2017
commit 8b46d5e9ab6eebcb9a7d92b995d2a0b483801fba
4 changes: 2 additions & 2 deletions lib/console.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

const util = require('util');

function Console(stdout, stderr, ignoreErrors) {
function Console(stdout, stderr, ignoreErrors = true) {
if (!(this instanceof Console)) {
return new Console(stdout, stderr, ignoreErrors);
}
Expand All @@ -24,7 +24,7 @@ function Console(stdout, stderr, ignoreErrors) {
Object.defineProperty(this, '_stdout', prop);
prop.value = stderr;
Object.defineProperty(this, '_stderr', prop);
prop.value = ignoreErrors === undefined ? true : !!ignoreErrors;
prop.value = ignoreErrors;
Object.defineProperty(this, '_ignoreErrors', prop);
prop.value = new Map();
Object.defineProperty(this, '_times', prop);
Expand Down