Skip to content

test: fix flaky test-dgram-empty-packet & friends #9724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 4 commits into from
Closed

test: fix flaky test-dgram-empty-packet & friends #9724

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5b2178a
test: fix flaky test-dgram-empty-packet & friends
Trott Nov 21, 2016
84abe59
squash: intervals
Trott Nov 23, 2016
e5a0a86
squash:nits
Trott Nov 24, 2016
2f73690
squash: nits
Trott Nov 24, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
squash: nits
  • Loading branch information
@Trott
Trott committed Nov 24, 2016
commit 2f73690877263e1e499696f7e9aa8cfa3aabcc13
4 changes: 3 additions & 1 deletion test/parallel/test-dgram-send-empty-packet.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
'use strict';
const common = require('../common');
const assert = require('assert');

if (common.isOSX) {
common.skip('because of 17894467 Apple bug');
Expand All @@ -23,8 +24,9 @@ client.bind(0, common.mustCall(function() {

function callback(firstArg) {
// If client.send() callback, firstArg should be null.
// If client.on('message') listener, firstArg should be the buffer.
// If client.on('message') listener, firstArg should be a 0-length buffer.
if (firstArg instanceof Buffer) {
assert.strictEqual(firstArg.length, 0);
clearInterval(interval);
client.close();
}
Expand Down