Skip to content

repl: Proposal for better repl (implementation) #9601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
princejwesley wants to merge 7 commits into from
Closed

repl: Proposal for better repl (implementation) #9601

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
48414f0
repl: REPL enhancements
princejwesley Sep 9, 2016
b34c110
Accidental change in Magic mode
princejwesley Apr 2, 2017
a60da69
Add back the missing DEP0024
princejwesley Apr 2, 2017
d6cee38
Use ContextifyScript instead of vm.js
princejwesley Apr 2, 2017
f304f8c
Remove VM string in welcome message
princejwesley Apr 2, 2017
2d5feff
Add doc for ^M and ^J
princejwesley Apr 3, 2017
a3047dc
Move ArrayStream.run to prototype
princejwesley Apr 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove VM string in welcome message
  • Loading branch information
@princejwesley
princejwesley committed Apr 2, 2017
commit f304f8c9dff175fda42b672818c82640192767cd
2 changes: 1 addition & 1 deletion lib/repl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -561,7 +561,7 @@ function REPLServer(prompt,
const jsEngineVersion = process.versions[jsEngine];
const docURL = `https://nodejs.org/dist/${version}/docs/api/repl.html`;

const welcome = `Welcome to Node.js ${version} (${jsEngine} VM,` +
const welcome = `Welcome to Node.js ${version} (${jsEngine},` +
` ${jsEngineVersion})\nType ^M or enter to execute,` +

@TimothyGu TimothyGu Apr 2, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Node.js ${version} (${jsEngine} ${jsEngineVersion}) should suffice; the "VM" seems a bit extraneous.

' ^J to continue, ^C to exit\n' +
`Or try .help for help, more at ${docURL}\n\n`;
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-repl-welcome-message.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ const jsEngine = process.jsEngine || 'v8';
const jsEngineVersion = process.versions[jsEngine];
const docURL = `https://nodejs.org/dist/${version}/docs/api/repl.html`;
const welcomeMessage =
`Welcome to Node.js ${version} (${jsEngine} VM,` +
`Welcome to Node.js ${version} (${jsEngine},` +
` ${jsEngineVersion})\nType ^M or enter to execute,` +
' ^J to continue, ^C to exit\n' +
`Or try .help for help, more at ${docURL}\n\n`;
Expand Down