Skip to content

test: remove timer in test-dgram-send-empty-array #9361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 1 commit into from
Closed

test: remove timer in test-dgram-send-empty-array #9361

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: remove timer in test-dgram-send-empty-array 
The timer is not necessary. The test will timeout via the test harness
if the test fails. This should resolve spurious CI failures.
  • Loading branch information
@Trott
Trott committed Oct 29, 2016
commit 00af65975aa2b45b31c0b816db29a6b099f22ffd
5 changes: 0 additions & 5 deletions test/parallel/test-dgram-send-empty-array.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,9 @@ if (common.isOSX) {

const client = dgram.createSocket('udp4');

const timer = setTimeout(function() {
throw new Error('Timeout');
}, common.platformTimeout(200));

client.on('message', common.mustCall(function onMessage(buf, info) {
const expected = Buffer.alloc(0);
assert.ok(buf.equals(expected), 'message was received correctly');
clearTimeout(timer);
client.close();
}));

Expand Down