Skip to content

https: name anonymous functions in https #9217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pvsousalima wants to merge 3 commits into from
Closed

https: name anonymous functions in https #9217

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
156b70a
https: name anonymous functions in https
pvsousalima Oct 21, 2016
fd487fa
https: name anonymous functions
pvsousalima Oct 25, 2016
3d00f17
https: name anonymous functions in https
pvsousalima Oct 21, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
https: name anonymous functions in https 
related to commit ef030da
which is naming anonymous functions to standardize the code
  • Loading branch information
@pvsousalima
pvsousalima committed Oct 27, 2016
commit 3d00f1774010a77216c44a0cf4bc432aa4828621
8 changes: 4 additions & 4 deletions lib/https.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ exports.Server = Server;

Server.prototype.setTimeout = http.Server.prototype.setTimeout;

exports.createServer = function(opts, requestListener) {
exports.createServer = function createServer(opts, requestListener) {
return new Server(opts, requestListener);
};

Expand Down Expand Up @@ -112,7 +112,7 @@ function Agent(options) {
inherits(Agent, http.Agent);
Agent.prototype.createConnection = createConnection;

Agent.prototype.getName = function(options) {
Agent.prototype.getName = function getName(options) {
var name = http.Agent.prototype.getName.call(this, options);

name += ':';
Expand Down Expand Up @@ -186,7 +186,7 @@ const globalAgent = new Agent();
exports.globalAgent = globalAgent;
exports.Agent = Agent;

exports.request = function(options, cb) {
exports.request = function request(options, cb) {
if (typeof options === 'string') {
options = url.parse(options);
if (!options.hostname) {
Expand All @@ -199,7 +199,7 @@ exports.request = function(options, cb) {
return http.request(options, cb);
};

exports.get = function(options, cb) {
exports.get = function get(options, cb) {
var req = exports.request(options, cb);
req.end();
return req;
Expand Down