Skip to content

deps: v8 - cherry-pick missing v8 floating patch #8907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mhdawson wants to merge 1 commit into from
Closed

deps: v8 - cherry-pick missing v8 floating patch #8907

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
deps: v8 - cherry-pick missing v8 floating patch 
2d524bc

Original commit message:

deps: limit regress/regress-crbug-514081 v8 test

regress/regress-crbug-514081 allocates a 2G block of memory
and if there  are multiple variants running at the
same time this can lead to crashes, OOM kills or
the OS failing to allocate memory.  This patch
limits us to running a single variant of the test

Fixes: #6340
PR-URL: #6678
Reviewed-By: Ben Noorhduis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
  • Loading branch information
@mhdawson
mhdawson committed Oct 3, 2016
commit 1f295f8285657d80900e69c67cff299a09dc7b46
9 changes: 9 additions & 0 deletions deps/v8/test/mjsunit/mjsunit.status
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -925,4 +925,13 @@
'big-array-literal': [SKIP],
}], # 'gcov_coverage'

##############################################################################
# This test allocates a 2G block of memory and if there are multiple
# varients this leads kills by the OOM killer, crashes or messages
# indicating the OS cannot allocate memory, exclude for Node.js runs
# re-evalute when we move up to v8 5.1
[ALWAYS, {
'regress/regress-crbug-514081': [PASS, NO_VARIANTS],
}], # ALWAYS

]