Skip to content

module: NativeModule._cache turned to a Map #8576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danyshaanan wants to merge 1 commit into from
Closed

module: NativeModule._cache turned to a Map #8576

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
module: NativeModule._cache turned to a Map
  • Loading branch information
@danyshaanan
danyshaanan committed Sep 17, 2016
commit da14c6bc14e15cec0a3f9d128f0c7ab0bd8550df
6 changes: 3 additions & 3 deletions lib/internal/bootstrap_node.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,7 +402,7 @@
}

NativeModule._source = process.binding('natives');
NativeModule._cache = {};
NativeModule._cache = new Map();

NativeModule.require = function(id) {
if (id == 'native_module') {
Expand All @@ -429,7 +429,7 @@
};

NativeModule.getCached = function(id) {
return NativeModule._cache[id];
return NativeModule._cache.get(id);
};

NativeModule.exists = function(id) {
Expand Down Expand Up @@ -491,7 +491,7 @@
};

NativeModule.prototype.cache = function() {
NativeModule._cache[this.id] = this;
NativeModule._cache.set(this.id, this);
};

startup();
Expand Down