Skip to content

fs,module: add module-loader-only realpath cache #8100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 5 commits into from
Closed

fs,module: add module-loader-only realpath cache #8100

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
020ba8b
fs,module: add module-loader-only realpath cache
addaleax Aug 14, 2016
434424f
Replace `cache.has` with `.get()` & check.
addaleax Aug 14, 2016
7f0c224
Use local `const` instead of property on `Module` object
addaleax Aug 18, 2016
f3e8373
Address review comments
addaleax Sep 10, 2016
c9954f4
fixup: `id` cannot be const
addaleax Sep 10, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use local const instead of property on Module object
  • Loading branch information
@addaleax
addaleax committed Sep 10, 2016
commit 7f0c2245355311b14b47e2e6f735811c363660f8
4 changes: 2 additions & 2 deletions lib/module.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ function tryPackage(requestPath, exts, isMain) {
// In order to minimize unnecessary lstat() calls,
// this cache is a list of known-real paths.
// Set to an empty object to reset.
Module._realpathCache = new Map();
const realpathCache = new Map();

const realpathCacheKey = fs.realpathCacheKey;
delete fs.realpathCacheKey;
Expand All @@ -131,7 +131,7 @@ function tryFile(requestPath, isMain) {

function toRealPath(requestPath) {
return fs.realpathSync(requestPath, {
[realpathCacheKey]: Module._realpathCache
[realpathCacheKey]: realpathCache
});
}

Expand Down