Skip to content

build: add node_module_version to config.gypi #8027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
saper wants to merge 3 commits into from
Closed

build: add node_module_version to config.gypi #8027

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fc6d820
build: turn on -fno-delete-null-pointer-checks
bnoordhuis May 13, 2016
a14d5ae
test: fix test failure due to expired certificates
bnoordhuis Jun 7, 2016
addfeaa
build: add node_module_version to config.gypi
saper Jul 20, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
build: turn on -fno-delete-null-pointer-checks 
Work around spec violations in V8 where it checks that `this == NULL`.
GCC 6 started exploiting this particular kind of UB, resulting in
runtime crashes.

Fixes: #6724
PR-URL: #6737
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
  • Loading branch information
@bnoordhuis @jasnell
bnoordhuis authored and jasnell committed May 25, 2016
commit fc6d820609035f2c5ff62bd5f60b3fff48f2d605
6 changes: 5 additions & 1 deletion common.gypi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,11 @@
}],
[ 'OS in "linux freebsd openbsd solaris android"', {
'cflags': [ '-Wall', '-Wextra', '-Wno-unused-parameter', ],
'cflags_cc': [ '-fno-rtti', '-fno-exceptions' ],
'cflags_cc': [
'-fno-delete-null-pointer-checks',
'-fno-exceptions',
'-fno-rtti',
],
'ldflags': [ '-rdynamic' ],
'target_conditions': [
['_type=="static_library"', {
Expand Down