Skip to content

doc: add npm link to Readme, general cleanup #7769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
oscarmorrison wants to merge 4 commits into from
Closed

doc: add npm link to Readme, general cleanup #7769

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
38e139b
doc: add npm link, formatting
oscarmorrison Jul 16, 2016
4961525
doc: formatting, based on feedback.
oscarmorrison Jul 16, 2016
88cc765
doc: updated nam link to npmjs.com
oscarmorrison Jul 17, 2016
0b074c2
doc: update nodejs.org url, remove en
oscarmorrison Jul 20, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
doc: add npm link, formatting 
README.md missing npm link
removed unnecessary comma
formatted links for consistency and readability
  • Loading branch information
@oscarmorrison
oscarmorrison authored Jul 16, 2016
commit 38e139bf6eb93a6024c0cf78ee1663f055b95791
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ Node.js

Node.js is a JavaScript runtime built on Chrome's V8 JavaScript engine. Node.js
uses an event-driven, non-blocking I/O model that makes it lightweight and
efficient. The Node.js package ecosystem, npm, is the largest ecosystem of open
efficient. The Node.js package ecosystem [npm](https://github.com/npm/npm), is the largest ecosystem of open

@ChALkeR ChALkeR Jul 16, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Long line.

source libraries in the world.

The Node.js project is supported by the
Expand All @@ -19,8 +19,8 @@ If you need help using or installing Node.js, please use the

## Resources for Newcomers

* [Website](https://nodejs.org/en/)
* [Contributing to the project](./CONTRIBUTING.md)
* Website: [nodejs.org](https://nodejs.org/en/)

@cjihrig cjihrig Jul 18, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this wasn't part of this PR, but does anyone know why we are sending everyone to /en?

@ChALkeR ChALkeR Jul 18, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ref: #6681, /cc @Fishrock123.

@Fishrock123 Fishrock123 Jul 18, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No reason, it was a copy-paste of what the default is.

This should be fixed.

* Project Contributing: [CONTRIBUTING.md](./CONTRIBUTING.md)

@ChALkeR ChALkeR Jul 16, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not a native English speaker, but «Project Contributing» does sound a little suspicious to me.
/cc @nodejs/documentation

* IRC (general questions): [#node.js on chat.freenode.net](https://webchat.freenode.net?channels=node.js&uio=d4)
* IRC (node core development): [#node-dev on chat.freenode.net](https://webchat.freenode.net?channels=node-dev&uio=d4)

Expand Down