Skip to content

test: test isFullWidthCodePoint with invalid input #7422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 2 commits into from
Closed

test: test isFullWidthCodePoint with invalid input #7422

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae0ef11
test: test isFullWidthCodePoint with invalid input
Trott Jun 25, 2016
6d71146
squash: add more non-numeric primitives
Trott Jun 28, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: test isFullWidthCodePoint with invalid input 
Code coverage information shows that we are only testing the happy path
for the internal readline `isFullWidthCodePoint()` function. Test it
with invalid input.
  • Loading branch information
@Trott
Trott committed Jun 28, 2016
commit ae0ef11b1988ebeeaa1a0fed9c10610273d37268
3 changes: 3 additions & 0 deletions test/parallel/test-readline-interface.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,6 +327,9 @@ function isWarned(emitter) {
rli.close();
}

// isFullWidthCodePoint() should return false for non-numeric values
assert.strictEqual(internalReadline.isFullWidthCodePoint('あ'), false);

@bnoordhuis bnoordhuis Jun 27, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps you can extend this to [true, false, null, undefined, {}, [], 'あ'].forEach((v) => {?


// wide characters should be treated as two columns.
assert.equal(internalReadline.isFullWidthCodePoint('a'.charCodeAt(0)), false);
assert.equal(internalReadline.isFullWidthCodePoint('あ'.charCodeAt(0)), true);
Expand Down