Skip to content

test: fix flaky test-fs-watch-encoding on OS X #7356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 4 commits into from
Closed

test: fix flaky test-fs-watch-encoding on OS X #7356

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
57e3e41
test: fix flaky test-fs-watch-encoding on OS X
Trott Jun 22, 2016
a05df90
squash: fixes for SmartOS and OS X
Trott Jun 22, 2016
9204c92
squash: typo fix
Trott Jun 22, 2016
7924224
squash: test now works in FreeBSD?
Trott Jun 22, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
squash: fixes for SmartOS and OS X
  • Loading branch information
@Trott
Trott committed Jun 22, 2016
commit a05df90af3a0158dfb67277f07c56efc9b7693ab
29 changes: 20 additions & 9 deletions test/parallel/test-fs-watch-encoding.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,18 @@
'use strict';

// This test is a bit more complicated than it ideally needs to be to work
// around issues on OS X and SmartOS.
//
// On OS X, watch events are subject to peculiar timing oddities such that an
// event might fire our of order. The synchronous refreshing of the tmp

@bnoordhuis bnoordhuis Jun 22, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/our/out/

// directory might trigger an event on the watchers that are instantiated after
// it!
//
// On SmartOS, the watch events fire but the filename is null.

const common = require('../common');
const fs = require('fs');
const path = require('path');
const assert = require('assert');

if (common.isFreeBSD) {
common.skip('Test currently not working on FreeBSD');

@santigimeno santigimeno Jun 22, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove this. The test now passes in FreeBSD because of the interval

Expand Down Expand Up @@ -33,18 +42,17 @@ const watcher1 = fs.watch(
common.tmpDir,
{encoding: 'hex'},
(event, filename) => {
console.log(event);
assert.equal(filename, 'e696b0e5bbbae69687e5a4b9e4bbb62e747874');
unregisterWatcher(watcher1);
if (['e696b0e5bbbae69687e5a4b9e4bbb62e747874', null].includes(filename))
done(watcher1);
}
);
registerWatcher(watcher1);

const watcher2 = fs.watch(
common.tmpDir,
(event, filename) => {
assert.equal(filename, fn);
unregisterWatcher(watcher2);
if ([fn, null].includes(filename))
done(watcher2);
}
);
registerWatcher(watcher2);
Expand All @@ -53,13 +61,16 @@ const watcher3 = fs.watch(
common.tmpDir,
{encoding: 'buffer'},
(event, filename) => {
assert(filename instanceof Buffer);
assert.equal(filename.toString('utf8'), fn);
unregisterWatcher(watcher3);
if (filename instanceof Buffer && filename.toString('utf8') === fn)
done(watcher3);
else if (filename === null)
done(watcher3);
}
);
registerWatcher(watcher3);

const done = common.mustCall(unregisterWatcher, watchers.size);

// OS X and perhaps other systems can have surprising race conditions with
// file events. So repeat the operation in case it is missed the first time.
const interval = setInterval(() => {
Expand Down