Skip to content

test: improve debug-break-on-uncaught reliability #6793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 3 commits into from
Closed

test: improve debug-break-on-uncaught reliability #6793

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e003338
test: improve debug-break-on-uncaught reliability
Trott May 16, 2016
dcf13b2
squash
Trott May 21, 2016
b1eda6b
squash: encoding
Trott May 23, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
squash: encoding
  • Loading branch information
@Trott
Trott committed May 23, 2016
commit b1eda6b914166f77e21007e4b60ae356be058be3
3 changes: 2 additions & 1 deletion test/debugger/test-debug-break-on-uncaught.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,13 +47,14 @@ function runScenario(scriptName, throwsOnLine, next) {
var stderr = '';

function stderrListener(data) {
stderr += data.toString();
stderr += data;
if (stderr.includes('Debugger listening on port')) {
setTimeout(setupClient.bind(null, runTest), 200);
child.stderr.removeListener('data', stderrListener);
}
}

child.stderr.setEncoding('utf8');
child.stderr.on('data', stderrListener);

function setupClient(callback) {
Expand Down