Skip to content

ffi: add binary parameter to internal binding type #66502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
Oct 20, 2026
Merged

ffi: add binary parameter to internal binding type #66502

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
ffi: add binary parameter to internal binding type 
Add the optional binary parameter to the DynamicLibrary constructor
declaration to match the native binding introduced in #65909.

Signed-off-by: HoonDongKang <d159123@naver.com>
  • Loading branch information
@HoonDongKang
HoonDongKang committed Oct 4, 2026
commit 7d96a5588ce9144dcc72de48931eb845767e1fe9
2 changes: 1 addition & 1 deletion typings/internalBinding/ffi.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ declare namespace InternalFFIBinding {
}

class DynamicLibrary {
constructor(path: string | null);
constructor(path: string | null, binary?: ArrayBufferView);

readonly path: string;
readonly symbols: Record<string, bigint>;
Expand Down
Loading