build: fix vcbuild lint skipping lint-md-build - #66467
Open
vedchaudhari wants to merge 1 commit into
Open
vedchaudhari wants to merge 1 commit into
vedchaudhari wants to merge 1 commit into
Conversation
Jump to lint-md-build so vcbuild lint installs the Markdown linter. Assisted-by: Claude Code Signed-off-by: vedchaudhari <vedc2853@gmail.com>
nodejs-github-bot
added
build
Contributor
|
Welcome to Node.js, and thank you for your first contribution! Before review, please take a moment to read:
Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal. |
aduh95
approved these changes
Oct 2, 2026
aduh95
added
author ready
github-actions
Bot
removed
the
request-ci
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
vcbuild lintwas run on Windows from a fresh git clone, it failed withLinting is not available through the source tarball.The Markdown linter wasn't installed because the:lint-js-fixpath skippedlint-md-build.This PR fixes the issue by changing the
gotofromlint-mdtolint-md-build. The other path from:lint-js-fixalready goes tolint-md-build. Similar to #61318.I deleted
tools\lint-md\node_modulesand confirmed thatvcbuild lint,vcbuild lint-js, andvcbuild lint-mdall run successfully. There are no automated tests forvcbuild.bat, so I tested the fix manually.Refs: #61318
Assisted-by: Claude Code (Claude Opus 5.5)