Skip to content

stream: share webstreams async iterator methods #66392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
Oct 5, 2026
Merged

stream: share webstreams async iterator methods #66392

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d9a4f3
stream: share webstreams async iterator methods
mcollina Sep 28, 2026
01fc4d2
stream: add webstreams async iterator toStringTag
mcollina Oct 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
stream: add webstreams async iterator toStringTag 
WebIDL gives an async iterator prototype the class string
"<interface> AsyncIterator", so ReadableStream iterators now report
'ReadableStream AsyncIterator' through Symbol.toStringTag.

Signed-off-by: Matteo Collina <hello@matteocollina.com>
  • Loading branch information
@mcollina
mcollina committed Oct 2, 2026
commit 01fc4d2886973ff4c6a536e8c502c34918c9d466
2 changes: 2 additions & 0 deletions lib/internal/webstreams/readablestream.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -878,6 +878,8 @@ ObjectSetPrototypeOf(ReadableStreamAsyncIterator.prototype,
ObjectDefineProperties(ReadableStreamAsyncIterator.prototype, {
next: kEnumerableProperty,
return: kEnumerableProperty,
[SymbolToStringTag]:
getNonWritablePropertyDescriptor('ReadableStream AsyncIterator'),
});

class DefaultReadRequest {
Expand Down
13 changes: 12 additions & 1 deletion test/parallel/test-whatwg-readablestream-async-iterator-shape.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,18 @@ const proto = Object.getPrototypeOf(a);

assert.strictEqual(Object.getPrototypeOf(b), proto);
assert.deepStrictEqual(Reflect.ownKeys(a), []);
assert.deepStrictEqual(Reflect.ownKeys(proto), ['next', 'return']);
assert.deepStrictEqual(Reflect.ownKeys(proto),
['next', 'return', Symbol.toStringTag]);
assert.strictEqual(Object.prototype.toString.call(a),
'[object ReadableStream AsyncIterator]');
assert.deepStrictEqual(
Object.getOwnPropertyDescriptor(proto, Symbol.toStringTag),
{
value: 'ReadableStream AsyncIterator',
writable: false,
enumerable: false,
configurable: true,
});
assert.strictEqual(a[Symbol.asyncIterator](), a);

for (const method of ['next', 'return']) {
Expand Down
Loading