Skip to content

test: fix timing and environment flakes #66320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
panva wants to merge 9 commits into from
Closed

test: fix timing and environment flakes #66320

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
30dd6c2
test: deflake inspector network fetch
panva Sep 26, 2026
c81cdc3
test: deflake debugger PID attachment and cleanup
panva Sep 26, 2026
924f8bd
test: deflake inspector close connection test
panva Sep 26, 2026
d494ccb
test: deflake http server mixed request timeouts
panva Sep 26, 2026
9737126
test: deflake http headers timeout keepalive
panva Sep 26, 2026
ba3fc1b
test: deflake esm loader http imports
panva Sep 26, 2026
26b5ef8
test: deflake watch cwd with isolation none
panva Sep 26, 2026
138db25
test: probe cluster workers with signal 0
panva Sep 26, 2026
11d7658
test: isolate styleText tests from the environment
panva Sep 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: deflake http headers timeout keepalive 
The second request in the headers-timeout test could finish its headers
before the next periodic timeout check ran. Leave it incomplete across
multiple checking intervals before sending the remaining headers.

Remove both macOS keepalive flaky expectations. c3aa86d already
extended the request-timeout test's margin to allow multiple checks.

Refs: #42741
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Assisted-by: Claude, Codex
  • Loading branch information
@panva
panva committed Sep 26, 2026
commit 9737126f91b648b5385c536f62d031a2944229f2
3 changes: 0 additions & 3 deletions test/parallel/parallel.status
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,6 @@ test-performance-function: PASS, FLAKY
test-esm-loader-hooks-inspect-wait: PASS, FLAKY

[$system==macos]
# https://github.com/nodejs/node/issues/42741
test-http-server-headers-timeout-keepalive: PASS,FLAKY
test-http-server-request-timeout-keepalive: PASS,FLAKY
# https://github.com/nodejs/node/issues/60050
test-cluster-dgram-1: SKIP

Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-http-server-headers-timeout-keepalive.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ server.listen(0, common.mustCall(() => {
performRequestWithDelay(
client,
headersTimeout / 5,
headersTimeout,
headersTimeout * 2,
true
);
}, defer).unref();
Expand Down