Skip to content

build: port make_temporal_zoneinfo_cpp to GYP #66183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
Sep 24, 2026
+38 −0
Merged

build: port make_temporal_zoneinfo_cpp to GYP #66183

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f13a5a
build: port `make_temporal_zoneinfo_cpp` to GYP
aduh95 Sep 21, 2026
5f874b7
fixup! build: port `make_temporal_zoneinfo_cpp` to GYP
aduh95 Sep 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
build: port make_temporal_zoneinfo_cpp to GYP 
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
  • Loading branch information
@aduh95
aduh95 committed Sep 21, 2026
commit 0f13a5ae3cf36cd688eda42d09c222a3eae19ef7
25 changes: 25 additions & 0 deletions tools/v8_gypfiles/v8.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1161,6 +1161,31 @@
'../../deps/crates/crates.gyp:temporal_capi',
],
}],
['v8_enable_i18n_support==0', {
'sources': [
'<(SHARED_INTERMEDIATE_DIR)/src/builtins/builtins-temporal-zoneinfo64-data.cc',
],
'actions': [
{
'action_name': 'make_temporal_zoneinfo_cpp',
'inputs': [
'<(V8_ROOT)/tools/include-file-as-bytes.py',
'../../deps/crates/vendor/zoneinfo64-v0_3/src/data/zoneinfo64.res',
Comment thread
Renegade334 marked this conversation as resolved.
Outdated
],
'outputs': [
'<(SHARED_INTERMEDIATE_DIR)/src/builtins/builtins-temporal-zoneinfo64-data.cc',
],
'action': [
'<(python)',
'<(V8_ROOT)/tools/include-file-as-bytes.py',
'../../deps/crates/vendor/zoneinfo64-v0_3/src/data/zoneinfo64.res',
'<@(_outputs)',
'zoneinfo64_static_data',
],
'message': 'Generating zoneinfo64 static data for Temporal',
},
],
}],
],
'sources': [
'<!@pymod_do_main(GN-scraper "<(V8_ROOT)/BUILD.gn" "\\"v8_base_without_compiler.*?v8_enable_temporal_support.*?sources \\+= ")',
Expand Down
Loading