Skip to content

quic: add Http3Session, so you can explicitly pick the app protocol #65993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pimterry wants to merge 12 commits into
base: main
Choose a base branch
from
Open

quic: add Http3Session, so you can explicitly pick the app protocol #65993

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
1f983e3
quic: add Http3Session, so you can explicitly pick the app protocol
pimterry Sep 11, 2026
5990b89
fixup! quic: add Http3Session, so you can explicitly pick the app pro…
pimterry Sep 21, 2026
a13654d
quic: add kInspect & AsyncDispose to Http3Session
pimterry Sep 21, 2026
03e1b40
quic: replace PENDING application type flag with a separate state bit
pimterry Sep 24, 2026
8a9945a
quic: extract and validate Http3Settings separately into a fixed shape
pimterry Sep 28, 2026
792509f
quic: move HTTP/3 events to Http3Session, use .from() to attach
pimterry Sep 28, 2026
0e63cec
quic: fix subtle bugs in resume & failed H3 start teardown
pimterry Sep 28, 2026
954233d
quic: add autoWrap option to auto-attach HTTP/3
pimterry Sep 28, 2026
157777e
quic: move pure-QUIC fields back from Http3Session to QuicSession
pimterry Sep 28, 2026
c1d4200
quic: split quic connection & session, rename autoWrap to autoStart
pimterry Oct 7, 2026
ca63d86
quic: fix bug in setSNIContexts that lost ALPN config
pimterry Oct 7, 2026
e24abc9
quic: fix QUIC code broken by V8 update
pimterry Oct 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
quic: fix bug in setSNIContexts that lost ALPN config
  • Loading branch information
@pimterry
pimterry committed Oct 7, 2026
commit ca63d860221e13e8f601fbe4734dad0705c9ed24
6 changes: 5 additions & 1 deletion lib/internal/quic/quic.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4515,6 +4515,8 @@ class QuicEndpoint {
truncatedReads: undefined,
onsession: undefined,
sessionCallbacks: undefined,
// The encoded ALPN this endpoint listens with.
alpn: undefined,
};

static {
Expand Down Expand Up @@ -4823,6 +4825,7 @@ class QuicEndpoint {
} = options;

inner.truncatedReads = truncatedReads;
inner.alpn = rest.tls.alpn;

// Store session and stream callbacks to apply to each new incoming session.
inner.sessionCallbacks = {
Expand Down Expand Up @@ -5030,7 +5033,8 @@ class QuicEndpoint {
if (identity.certs === undefined) {
throw new ERR_MISSING_ARGS(`entries['${hostname}'].certs`);
}
processed[hostname] = identity;
// These identities offer the same protocols as the ones given to listen():
processed[hostname] = { __proto__: null, ...identity, alpn: this.#inner.alpn };
}

this.#handle.setSNIContexts(processed, replace);
Expand Down
5 changes: 4 additions & 1 deletion test/parallel/test-quic-sni-setcontexts.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,10 @@ const serverEndpoint = await listen(mustCall(async (serverSession) => {
}

endpoint.setSNIContexts(
{ '*': { keys: [key2], certs: [cert2] } },
{
'*': { keys: [key2], certs: [cert2] },
'localhost': { keys: [key2], certs: [cert2] },
},
{ replace: true },
);

Expand Down
Loading