Skip to content

test,tools: reduce CI test runtime #65980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
panva wants to merge 12 commits into from
Closed

test,tools: reduce CI test runtime #65980

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
2f52291
test: reduce ZIP64 stress test I/O
panva Sep 11, 2026
638fb88
test: use named parameters in DH stress test
panva Sep 11, 2026
57f6cf7
test: close WebAssembly test HTTP servers
panva Sep 11, 2026
0b65929
tools: reduce test runner timing overhead
panva Sep 11, 2026
092524b
test: avoid idle HTTP/HTTPS connections
panva Sep 11, 2026
cbb5bf2
test: reuse fixed primes in DH tests
panva Sep 11, 2026
7181c3c
test: synchronize ordered runner events
panva Sep 11, 2026
a088fbf
test: skip retries in DNS timeout coverage
panva Sep 11, 2026
f008c10
test: collect timeout signals explicitly
panva Sep 11, 2026
d4184b9
test: unref cancelled broadcast source timer
panva Sep 11, 2026
6c2d3c1
test: overlap SLH-DSA signature checks
panva Sep 11, 2026
d72070f
fixup! test: use named parameters in DH stress test
panva Sep 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: use named parameters in DH stress test 
Named modp14 parameters avoid generating and repeatedly validating a
custom prime. Keep the existing exchange counts and FIPS rejection
assertion. The separate deterministic padding test continues to cover
imported prime parameters.

Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Assisted-by: Codex
  • Loading branch information
@panva
panva committed Sep 11, 2026
commit 638fb885a33036a9741f50a5bcd8a0643506fa36
19 changes: 5 additions & 14 deletions test/pummel/test-dh-regr.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,32 +32,23 @@ if (common.isPi()) {

const assert = require('assert');
const crypto = require('crypto');
const { hasOpenSSL, hasFIPS } = require('../common/crypto');
const { hasFIPS } = require('../common/crypto');

let p;
let iterations = 2000;
if (hasFIPS(3)) {
assert.throws(() => crypto.createDiffieHellman(1024), {
code: 'ERR_INVALID_ARG_VALUE',
name: 'TypeError',
});

// Use a precomputed approved group instead of generating a 2048-bit prime
// for every test run. Its larger keys also make each pummel iteration more
// expensive, so use enough iterations to exercise the regression without
// making the FIPS job excessively slow.
p = crypto.getDiffieHellman('modp14').getPrime();
// Keep a lower iteration count for FIPS jobs.
iterations = 100;
} else {
// FIPS requires length >= 1024, but small parameters keep this pummel test
// from timing out in ordinary CI.
const length = crypto.getFips() === 1 ? 1024 : (hasOpenSSL(3) ? 512 : 256);
p = crypto.createDiffieHellman(length).getPrime();
}

for (let i = 0; i < iterations; i++) {
const a = crypto.createDiffieHellman(p);
const b = crypto.createDiffieHellman(p);
// A named group avoids generating and validating custom parameters.
const a = crypto.getDiffieHellman('modp14');
const b = crypto.getDiffieHellman('modp14');

a.generateKeys();
b.generateKeys();
Expand Down