Skip to content

quic: add promise to QuicStream for pending strms #65862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 7 commits into from
Sep 12, 2026
+109 −1
Merged

quic: add promise to QuicStream for pending strms #65862

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5fd0f60
quic: add promise to QuicStream for pending strms
martenrichter Sep 6, 2026
5f205d5
quic: fix lint
martenrichter Sep 6, 2026
a21a26e
quic: use opened instead ready for QuicStream
martenrichter Sep 8, 2026
dc01a8d
quic: fix rejection of opened promise and add test
martenrichter Sep 8, 2026
5570ac6
quic: fix lint and test
martenrichter Sep 8, 2026
ddfdc5d
quic: fix doc opened instead of open
martenrichter Sep 9, 2026
4db975e
quic: move EmitStreamAvailable
martenrichter Sep 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
quic: fix lint
  • Loading branch information
@martenrichter
martenrichter committed Sep 9, 2026
commit 5f205d51b7acf578708a5b7ec37126c75a23ea50
2 changes: 2 additions & 0 deletions test/parallel/test-quic-stream-limits-pending.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ const s1 = await clientSession.createBidirectionalStream({
body: encoder.encode('stream 1'),
});

// eslint-disable-next-line node-core/must-call-assert
s1.ready.then(() => {
ready++;
});
Expand All @@ -55,6 +56,7 @@ const s2 = await clientSession.createBidirectionalStream({
body: encoder.encode('stream 2'),
});

// eslint-disable-next-line node-core/must-call-assert
s2.ready.then(() => {
ready++;
});
Expand Down
2 changes: 2 additions & 0 deletions test/parallel/test-quic-stream-limits-uni.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ const s1 = await clientSession.createUnidirectionalStream({
body: encoder.encode('uni 1'),
});

// eslint-disable-next-line node-core/must-call-assert
s1.ready.then(() => {
ready++;
});
Expand All @@ -50,6 +51,7 @@ const s2 = await clientSession.createUnidirectionalStream({
body: encoder.encode('uni 2'),
});

// eslint-disable-next-line node-core/must-call-assert
s2.ready.then(() => {
ready++;
});
Expand Down