Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
c9c5662
doc: add sxa GPG key (ed25519)
sxa Jun 29, 2026
44cf27b
build: update binary-upload to use correct tarball name
sxa Aug 16, 2026
e306521
deps: update icu to 78.3
nodejs-github-bot Mar 20, 2026
66de634
node-api: add napi_create_external_sharedarraybuffer
bnoordhuis Apr 17, 2026
e5a6fde
tools: update gyp-next to 0.22.1
nodejs-github-bot Apr 28, 2026
6d6c3c9
deps: update timezone to 2026b
nodejs-github-bot Apr 28, 2026
5286330
deps: update corepack to 0.34.7
nodejs-github-bot Apr 28, 2026
fdc65e4
tools: use different branch for tool updates on staging branches
aduh95 May 11, 2026
3909ff2
node-api: support SharedArrayBuffer in napi_create_typedarray
umuoy1 May 13, 2026
23fb398
deps: update corepack to 0.35.0
nodejs-github-bot May 19, 2026
71feba6
crypto: update root certificates to NSS 3.123.1
nodejs-github-bot May 26, 2026
d9cb846
doc: clarify `filter` option of `sqlite.database.applyChangeset`
aduh95 May 26, 2026
38ee2e8
tools: avoid test/fixtures/wpt/README.md conflicts
panva Jun 16, 2026
01855a1
deps: c-ares: cherry-pick 8ba37af8e3fb
Renegade334 Jun 26, 2026
d68ee9f
tools: validate version number in release proposal commit message lint
aduh95 Jun 29, 2026
bc5753d
tools: remove `envinfo` from our workflows
aduh95 Jul 4, 2026
7d82841
deps: update c-ares to 1.34.8
nodejs-github-bot Jul 8, 2026
4e4bd1b
deps: update timezone to 2026c
nodejs-github-bot Jul 21, 2026
fe2a6b2
crypto: update root certificates to NSS 3.125
nodejs-github-bot Aug 2, 2026
6f6cd37
tools: sync mk-ca-bundle.pl with curl
Archkon Aug 5, 2026
5fbbad6
url: handle unparsable serialized URLs in setters
mcollina Aug 5, 2026
ed019e4
util: preserve function names without source map names
privatenumber Aug 13, 2026
ce91391
src: escape Windows environment variables in task runner
aduh95 Aug 13, 2026
02cafc4
tools: fix commit linter for semver-major release proposals
aduh95 Apr 27, 2026
7c2df5d
http2: avoid uaf while receiving and sending rst_stream
Eusgor Jul 17, 2026
b816fc8
deps: upgrade npm to 10.9.9
npm-cli-bot Aug 24, 2026
3376e27
deps: V8: cherry-pick a6eaf7574109
camillobruni May 27, 2024
08b6ac0
tools: revert OpenSSL update workflow to ubuntu-latest
richardlau Apr 7, 2026
75098a9
tools: update gr2m/create-or-update-pull-request-action to v1.10.1
MikeMcC399 May 4, 2026
a9cb311
deps: upgrade openssl sources to openssl-3.5.8
nodejs-github-bot Aug 25, 2026
59d853a
deps: update archs files for openssl-3.5.8
nodejs-github-bot Aug 25, 2026
40eac4a
test: account for varied OpenSSL CCM final behaviours
panva Aug 26, 2026
839480a
test: fix link-local dgram scope assertion
panva Aug 28, 2026
2a3548e
deps: update undici to 6.28.1
mcollina Sep 4, 2026
37f2106
fs: restore fs patchability in ESM loader
joyeecheung Apr 22, 2026
871167d
deps: update corepack to 0.36.0
nodejs-github-bot Sep 1, 2026
80dc632
2026-09-23, Version 22.23.3 'Jod' (LTS)
aduh95 Sep 22, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
build: update binary-upload to use correct tarball name
the binary-upload target uses $(TARNAME)-$(OSTYPE)-$(ARCH).tar.xz as the
name to upload whereas it is created by the $(BINARYTAR) target as
$(BINARYNAME). Since BINARYNAME includes the optional VARIATION when
present this gets missed out int he binary-upload target, for example
during a release build for Alpine/musl. This commit changes the
binary-upload target to use the same variable for the tarball that is
used when the file is created.

Signed-off-by: Stewart X Addison <sxa@ibm.com>
PR-URL: #65282
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>
  • Loading branch information
sxa authored and juanarbol committed Aug 21, 2026
commit 44cf27b8fa785bd25981d3f7a063c3996230f1f2
16 changes: 8 additions & 8 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -1375,15 +1375,15 @@ binary: $(BINARYTAR) ## Build release binary tarballs.
# Note: this is strictly for release builds on release machines only.
binary-upload: binary
ssh $(STAGINGSERVER) "mkdir -p nodejs/$(DISTTYPEDIR)/$(FULLVERSION)"
chmod 664 $(TARNAME)-$(OSTYPE)-$(ARCH).tar.gz
scp -p $(TARNAME)-$(OSTYPE)-$(ARCH).tar.gz $(STAGINGSERVER):nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/$(TARNAME)-$(OSTYPE)-$(ARCH).tar.gz
ssh $(STAGINGSERVER) "rclone copyto nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/$(TARNAME)-$(OSTYPE)-$(ARCH).tar.gz $(CLOUDFLARE_BUCKET)/nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/$(TARNAME)-$(OSTYPE)-$(ARCH).tar.gz"
ssh $(STAGINGSERVER) "touch nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/$(TARNAME)-$(OSTYPE)-$(ARCH).tar.gz.done"
chmod 664 $(BINARYNAME).tar.gz
scp -p $(BINARYNAME).tar.gz $(STAGINGSERVER):nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/$(BINARYNAME).tar.gz
ssh $(STAGINGSERVER) "rclone copyto nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/$(BINARYNAME).tar.gz $(CLOUDFLARE_BUCKET)/nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/$(BINARYNAME).tar.gz"
ssh $(STAGINGSERVER) "touch nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/$(BINARYNAME).tar.gz.done"
ifeq ($(XZ), 1)
chmod 664 $(TARNAME)-$(OSTYPE)-$(ARCH).tar.xz
scp -p $(TARNAME)-$(OSTYPE)-$(ARCH).tar.xz $(STAGINGSERVER):nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/$(TARNAME)-$(OSTYPE)-$(ARCH).tar.xz
ssh $(STAGINGSERVER) "rclone copyto nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/$(TARNAME)-$(OSTYPE)-$(ARCH).tar.xz $(CLOUDFLARE_BUCKET)/nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/$(TARNAME)-$(OSTYPE)-$(ARCH).tar.xz"
ssh $(STAGINGSERVER) "touch nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/$(TARNAME)-$(OSTYPE)-$(ARCH).tar.xz.done"
chmod 664 $(BINARYNAME).tar.xz
scp -p $(BINARYNAME).tar.xz $(STAGINGSERVER):nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/$(BINARYNAME).tar.xz
ssh $(STAGINGSERVER) "rclone copyto nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/$(BINARYNAME).tar.xz $(CLOUDFLARE_BUCKET)/nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/$(BINARYNAME).tar.xz"
ssh $(STAGINGSERVER) "touch nodejs/$(DISTTYPEDIR)/$(FULLVERSION)/$(BINARYNAME).tar.xz.done"
endif

.PHONY: bench-all
Expand Down