Skip to content

tools: improve commit queue failure comment #65433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 5 commits into from
Aug 22, 2026
Merged

tools: improve commit queue failure comment #65433

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b9eeb1c
tools: improve commit queue failure comment
panva Aug 20, 2026
e513b51
fixup! tools: improve commit queue failure comment
panva Aug 20, 2026
fba2d8e
fixup! tools: improve commit queue failure comment
panva Aug 20, 2026
c430905
fixup! tools: improve commit queue failure comment
panva Aug 20, 2026
ff70e58
Update tools/actions/commit-queue.sh
panva Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! tools: improve commit queue failure comment 
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
  • Loading branch information
@panva
panva committed Aug 20, 2026
commit fba2d8e9e0e2a7e6738e997bf22e4d24a3f33f7c
30 changes: 11 additions & 19 deletions tools/actions/commit-queue.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,26 +10,18 @@ COMMIT_QUEUE_FAILED_LABEL="commit-queue-failed"

cqurl="${GITHUB_SERVER_URL:?}/${GITHUB_REPOSITORY:?}/actions/runs/${GITHUB_RUN_ID:?}"

fence_code_block() {
fence='```'
escape_code_block_or_line() {
case $1 in
*"
"*|'') fence='```' sep='
' ;;
*[![:space:]]*) fence='`' sep=' ' ;;
*) fence='`' sep='' ;;
esac
while case $1 in *"$fence"*) ;; *) false ;; esac; do
fence=$fence'`'
done
printf '%s\n%s\n%s\n' "$fence" "$1" "$fence"
}

format_diagnostics() {
awk '
function code_span(line, fence) {
fence = "`"
while (index(line, fence) != 0)
fence = fence "`"
return fence " " line " " fence
}
NR > 1 { printf " \n" }
{ printf "%s", code_span($0) }
END { if (NR > 0) printf "\n" }
'
printf '%s%s%s%s%s\n' "$fence" "$sep" "$1" "$sep" "$fence"
}

commit_queue_failed() {
Expand All @@ -54,11 +46,11 @@ Add https://github.com/nodejs/node/labels/commit-queue-squash to land it as one
if [ -z "$reported_failure" ]; then
reported_failure='No failure reason was reported.'
fi
failure_body=$(printf '%s\n' "$reported_failure" | format_diagnostics)
failure_body=$(escape_code_block_or_line "$reported_failure")
fi

raw_output=$(cat output)
full_output=$(fence_code_block "$raw_output")
full_output=$(escape_code_block_or_line "$raw_output")

Comment thread
panva marked this conversation as resolved.
body="### Commit Queue failed

Expand Down
Loading