Skip to content

http,http2: speed up header validation and write coalescing #65332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anonrig wants to merge 11 commits into
base: main
Choose a base branch
from
Open

http,http2: speed up header validation and write coalescing #65332

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
fbb6c1c
http,http2: speed up header validation and write coalescing
anonrig Aug 16, 2026
62327c4
http,http2: coalesce chunked end() and cache status lines
anonrig Aug 16, 2026
1a2c1ed
http: write coalesced chunked headers as latin1
anonrig Aug 16, 2026
69766d5
http: keep regex header-value checks
anonrig Aug 16, 2026
1ec86ff
http: keep incoming headers in C++ until accessed
anonrig Aug 16, 2026
5554cbc
http: keep incoming headers packed until accessed
anonrig Aug 16, 2026
4ca2f93
http: format and lint node_http_parser.cc
anonrig Aug 17, 2026
1663db2
http: address review feedback for packed headers
cursoragent Aug 17, 2026
df53247
http: fix lint in review-feedback follow-up
cursoragent Aug 17, 2026
855b729
test: add --expose-internals flags for packed header tests
cursoragent Aug 18, 2026
37317f2
test: cover packed-header fallbacks after materialization
cursoragent Aug 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: cover packed-header fallbacks after materialization 
Exercise _hasHeader/_getHeader/_hasBodyHeaders after rawHeaders is
materialized, plus empty name/value binding helpers, so the JS scan
paths stay covered once the C++ buffer is dropped.

Co-authored-by: Yagiz Nizipli <anonrig@users.noreply.github.com>
  • Loading branch information
@cursoragent @anonrig
cursoragent and anonrig committed Aug 18, 2026
commit 37317f2bc3b4a1f611b7846d416513a9655e6553
20 changes: 20 additions & 0 deletions test/parallel/test-http-native-headers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,11 @@ function packHeaders(pairs, flags = 0) {
assert.deepStrictEqual(nativeHeadersToArray(packed, 2), ['Host', 'example.com']);
assert.strictEqual(nativeHeadersByteLength(packed), 8);

const emptyName = packHeaders(['', 'value', 'X-Empty', '']);
assert.deepStrictEqual(nativeHeadersToArray(emptyName), ['', 'value', 'X-Empty', '']);
assert.strictEqual(nativeHeadersGet(emptyName, 'x-empty'), '');
assert.strictEqual(nativeHeadersHas(emptyName, ''), true);

const truncated = packed.subarray(0, 14);
assert.strictEqual(nativeHeadersHas(truncated, 'host'), false);
assert.deepStrictEqual(nativeHeadersToArray(truncated), []);
Expand Down Expand Up @@ -116,6 +121,13 @@ const server = http.createServer(common.mustCallAtLeast((req, res) => {
const after = Object.getOwnPropertyDescriptor(req, 'rawHeaders');
assert.strictEqual(after.writable, true);
assert.strictEqual(typeof after.get, 'undefined');
// Fallback scans after the packed buffer is gone.
assert.strictEqual(req._hasHeader('host'), true);
assert.strictEqual(req._hasHeader('x-test'), true);
assert.strictEqual(req._hasHeader('x-missing'), false);
assert.strictEqual(req._getHeader('x-test'), 'one, two');
assert.strictEqual(req._getHeader('x-missing'), undefined);
assert.strictEqual(req._hasBodyHeaders(), false);
res.end('ok');
break;
}
Expand All @@ -135,18 +147,26 @@ const server = http.createServer(common.mustCallAtLeast((req, res) => {
assert.strictEqual(req._hasHeader('transfer-encoding'), true);
req.resume();
req.on('end', common.mustCall(() => {
assert.ok(req.rawHeaders.some((h) => h.toLowerCase() === 'transfer-encoding'));
assert.strictEqual(req._hasBodyHeaders(), true);
assert.strictEqual(req._hasHeader('transfer-encoding'), true);
res.end('ok');
}));
break;
}
case '/te': {
assert.strictEqual(req._hasHeader('te'), true);
assert.strictEqual(req._getHeader('te'), 'trailers');
assert.ok(req.rawHeaders.some((h) => h.toLowerCase() === 'te'));
assert.strictEqual(req._hasHeader('te'), true);
assert.strictEqual(req._getHeader('te'), 'trailers');
res.end('ok');
break;
}
case '/expect': {
assert.strictEqual(req._hasHeader('expect'), true);
assert.strictEqual(req._getHeader('expect'), '100-continue');
assert.ok(req.rawHeaders.some((h) => h.toLowerCase() === 'expect'));
assert.strictEqual(req._hasHeader('expect'), true);
assert.strictEqual(req._getHeader('expect'), '100-continue');
res.end('ok');
Expand Down
Loading