Skip to content

build: extract temporal_capi crate directory name into gyp variable #64482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
Jul 16, 2026
Merged

build: extract temporal_capi crate directory name into gyp variable #64482

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
build: extract temporal_capi crate directory name into gyp variable 
This is a no-op for current builds, but will allow the crate updater in
node-core-utils to update the include path with the new crate location,
as the crate directory names will include a version string.

Signed-off-by: Renegade334 <contact.9a5d6388@renegade334.me.uk>
  • Loading branch information
@Renegade334
Renegade334 committed Jul 13, 2026
commit ff3ad1ec9032d9df426ba3d93c0f27cbef0302eb
3 changes: 2 additions & 1 deletion deps/crates/crates.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
'variables': {
'cargo%': 'cargo',
'cargo_vendor_dir': './vendor',
'temporal_capi_dir': 'temporal_capi',
'cargo_rust_target%': '',
},
'conditions': [
Expand Down Expand Up @@ -120,7 +121,7 @@
],
'direct_dependent_settings': {
'include_dirs': [
'<(cargo_vendor_dir)/temporal_capi/bindings/cpp',
'<(cargo_vendor_dir)/<(temporal_capi_dir)/bindings/cpp',
],
},
},
Expand Down
Loading