Skip to content

net: introduce Socket#connecting property #6404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
indutny wants to merge 3 commits into from
Closed

net: introduce Socket#connecting property #6404

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9db9528
net: introduce `Socket#connecting` property
indutny Apr 26, 2016
f906cb3
...
indutny Apr 27, 2016
1ed27a3
fix
indutny Apr 27, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix
  • Loading branch information
@indutny
indutny committed Apr 27, 2016
commit 1ed27a33d2fe48cfe628796bf70ce7d0fdb5e36e
10 changes: 5 additions & 5 deletions test/parallel/test-net-socket-connecting.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,14 @@ const server = net.createServer((conn) => {
server.close();
}).listen(common.PORT, () => {
const client = net.connect(common.PORT, () => {
assert.equal(client.connecting, false);
assert.strictEqual(client.connecting, false);

// Legacy getter
assert.equal(client._connecting, false);
assert.strictEqual(client._connecting, false);
client.end();
})
assert.equal(client.connecting, true);
});
assert.strictEqual(client.connecting, true);

// Legacy getter
assert.equal(client._connecting, true);
assert.strictEqual(client._connecting, true);
});