Skip to content

src: do not track weak BaseObjects as childrens of Realms #63842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 3 commits into from
Closed

src: do not track weak BaseObjects as childrens of Realms #63842

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c232b86
src: allow tracking children in `MemoryTracker` with weak edges
addaleax Jun 10, 2026
d7df262
src: do not track weak `BaseObject`s as childrens of `Realm`s
addaleax Jun 10, 2026
afa6df1
fixup! src: do not track weak `BaseObject`s as childrens of `Realm`s
addaleax Jun 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! src: do not track weak BaseObjects as childrens of Realms
  • Loading branch information
@addaleax
addaleax committed Jun 12, 2026
commit afa6df1a7e1edb266f82f469cc0c1b7d1ec278bb
2 changes: 1 addition & 1 deletion src/base_object.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ void BaseObjectList::MemoryInfo(MemoryTracker* tracker) const {
// https://github.com/v8/v8/commit/e37cadf1143a8c5bbe44c0408186b5a26cc23863
// is available for us
tracker->Track(
bo, bo->persistent().IsWeak() ? MemoryTracker::KWeakEdge : nullptr);
bo, bo->persistent().IsWeak() ? MemoryTracker::kWeakEdge : nullptr);
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/cppgc_helpers.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ void CppgcWrapperList::MemoryInfo(MemoryTracker* tracker) const {
// TODO(addaleax): Add weak edges instead of no edges once
// https://github.com/v8/v8/commit/e37cadf1143a8c5bbe44c0408186b5a26cc23863
// is available for us
tracker->Track(ptr, MemoryTracker::KWeakEdge);
tracker->Track(ptr, MemoryTracker::kWeakEdge);
}
}
}
Expand Down
Loading