Skip to content

ffi: add experimental fast FFI call API for AArch64 and x86_64 #63068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 4 commits into from
Jun 16, 2026
Merged

ffi: add experimental fast FFI call API for AArch64 and x86_64 #63068

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bd5f757
ffi: add experimental fast FFI call API for AArch64 and x86_64
ShogunPanda Jun 11, 2026
56114e3
fixup
ShogunPanda Jun 12, 2026
b3dc44d
fixup
ShogunPanda Jun 15, 2026
734ac22
fixup
ShogunPanda Jun 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup 
Signed-off-by: Paolo Insogna <paolo@cowtech.it>
  • Loading branch information
@ShogunPanda
ShogunPanda committed Jun 15, 2026
commit 734ac22863e3447f628328770b38abcb7948de8e
76 changes: 46 additions & 30 deletions test/ffi/test-ffi-shared-buffer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,41 +373,57 @@ test('SB metadata is Symbol-keyed, attribute-hardened, and not leaked onto the w
assert.strictEqual(typeof sym, 'symbol', `${name} must be a Symbol`);
}

// Fast-API-eligible signatures bypass the SB wrapper and therefore do not
// carry SB metadata.
for (const [name, sym] of [
['kSbSharedBuffer', kSbSharedBuffer],
['kSbArguments', kSbArguments],
['kSbReturn', kSbReturn],
['kSbInvokeSlow', kSbInvokeSlow],
]) {
const desc = Object.getOwnPropertyDescriptor(rawFn, sym);
assert.strictEqual(desc, undefined, `${name} present on Fast API function`);
const rawSbDesc = Object.getOwnPropertyDescriptor(rawFn, kSbSharedBuffer);
const rawFnUsesFastFFI = rawSbDesc === undefined;

if (rawFnUsesFastFFI) {
// Fast-API-eligible signatures bypass the SB wrapper and therefore do not
// carry SB metadata.
for (const [name, sym] of [
['kSbSharedBuffer', kSbSharedBuffer],
['kSbArguments', kSbArguments],
['kSbReturn', kSbReturn],
['kSbInvokeSlow', kSbInvokeSlow],
]) {
const desc = Object.getOwnPropertyDescriptor(rawFn, sym);
assert.strictEqual(desc, undefined, `${name} present on Fast API function`);
}
}

// Fast string signatures carry parameter metadata so the JS wrapper can
// perform string-to-pointer conversion, but still do not carry SB state.
const rawStringFn = rawGetFunctionUnpatched.call(
rawLib, 'safe_strlen', { return: 'u64', arguments: ['string'] });
const paramsDesc = Object.getOwnPropertyDescriptor(rawStringFn, kFastArguments);
assert.ok(paramsDesc !== undefined, 'kFastArguments missing on Fast string function');
assert.strictEqual(paramsDesc.enumerable, false);
assert.strictEqual(paramsDesc.configurable, false);
assert.strictEqual(paramsDesc.writable, false);
assert.strictEqual(
Object.getOwnPropertyDescriptor(rawStringFn, kSbArguments), undefined);
assert.strictEqual(
Object.getOwnPropertyDescriptor(rawStringFn, kSbSharedBuffer), undefined);
assert.strictEqual(
Object.getOwnPropertyDescriptor(rawStringFn, kSbReturn), undefined);
assert.strictEqual(
Object.getOwnPropertyDescriptor(rawStringFn, kSbInvokeSlow), undefined);
if (rawFnUsesFastFFI) {
// Fast string signatures carry parameter metadata so the JS wrapper can
// perform string-to-pointer conversion, but still do not carry SB state.
const rawStringFn = rawGetFunctionUnpatched.call(
rawLib, 'safe_strlen', { return: 'u64', arguments: ['string'] });
const paramsDesc = Object.getOwnPropertyDescriptor(rawStringFn, kFastArguments);
assert.ok(paramsDesc !== undefined, 'kFastArguments missing on Fast string function');
assert.strictEqual(paramsDesc.enumerable, false);
assert.strictEqual(paramsDesc.configurable, false);
assert.strictEqual(paramsDesc.writable, false);
assert.strictEqual(
Object.getOwnPropertyDescriptor(rawStringFn, kSbArguments), undefined);
assert.strictEqual(
Object.getOwnPropertyDescriptor(rawStringFn, kSbSharedBuffer), undefined);
assert.strictEqual(
Object.getOwnPropertyDescriptor(rawStringFn, kSbReturn), undefined);
assert.strictEqual(
Object.getOwnPropertyDescriptor(rawStringFn, kSbInvokeSlow), undefined);
}

assert.deepStrictEqual(Object.keys(rawFn), ['pointer']);
const ownSyms = Object.getOwnPropertySymbols(rawFn);
assert.ok(!ownSyms.includes(kSbSharedBuffer));
assert.ok(!ownSyms.includes(kSbArguments));
assert.ok(!ownSyms.includes(kSbReturn));
if (rawFnUsesFastFFI) {
assert.ok(!ownSyms.includes(kSbSharedBuffer));
assert.ok(!ownSyms.includes(kSbArguments));
assert.ok(!ownSyms.includes(kSbReturn));
} else {
assert.ok(ownSyms.includes(kSbSharedBuffer));
assert.ok(ownSyms.includes(kSbArguments));
assert.ok(ownSyms.includes(kSbReturn));
assert.strictEqual(rawSbDesc.enumerable, false);
assert.strictEqual(rawSbDesc.configurable, false);
assert.strictEqual(rawSbDesc.writable, false);
}

// Internals must not be forwarded by `inheritMetadata`.
const { lib, functions } = ffi.dlopen(libraryPath, {
Expand Down
Loading