Skip to content

ffi: add shared-buffer fast path for numeric and pointer signatures #62918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 5 commits into from
Apr 28, 2026
Merged

ffi: add shared-buffer fast path for numeric and pointer signatures #62918

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f8e8910
benchmark: add benchmarks for ffi module
bengl Apr 21, 2026
1e5fbe6
ffi: add shared-buffer fast path for numeric and pointer signatures
bengl Apr 21, 2026
3db950d
fixup! ffi: add shared-buffer fast path for numeric and pointer signa…
bengl Apr 24, 2026
f6c7f2d
fixup! fixup! ffi: add shared-buffer fast path for numeric and pointe…
bengl Apr 24, 2026
575fa0b
fixup! fixup! fixup! ffi: add shared-buffer fast path for numeric and…
bengl Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
ffi: add shared-buffer fast path for numeric and pointer signatures 
Adds an ArrayBuffer-based invocation path for FFI functions whose
signatures are composed entirely of numeric types (i8..i64, u8..u64,
f32, f64, bool, char) and/or pointer types. The JS wrapper packs
arguments directly into a per-function AB via primordial DataView
setters and the C++ invoker (`InvokeFunctionSB`) reads them without
going through V8's `FunctionCallbackInfo`. Results are returned the same
way.

Pointer arguments use runtime dispatch: BigInt, null, and undefined take
the fast path, while Buffer, ArrayBuffer, ArrayBufferView, and String
fall back transparently to the classic `InvokeFunction` path via a
stashed `_invokeSlow` function. Signatures containing
non-numeric/non-pointer types also bypass the fast path.

The fast path is disabled on big-endian platforms.

Callers do not opt in, and the fast path is transparent in every way
users should rely on. One observable change: function wrappers returned
by `library.getFunction`, `library.getFunctions`, and `library.functions`
now have `.length` equal to the declared parameter count rather than
`0`. Code that relied on the previous value will need to be updated.

Signed-off-by: Bryan English <bryan@bryanenglish.com>
  • Loading branch information
@bengl
bengl committed Apr 27, 2026
commit 1e5fbe6567b77be1a41c072a40a5e308e1d9c7bb
2 changes: 2 additions & 0 deletions lib/ffi.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,8 @@ const {
toArrayBuffer,
} = internalBinding('ffi');

require('internal/ffi-shared-buffer');

function checkFFIPermission() {
if (!permission.isEnabled() || permission.has('ffi')) {
return;
Expand Down
Loading