Skip to content

[v22.x] deps: V8: backport Wasm exception handling correctness fixes #62783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
guybedford wants to merge 17 commits into from
Closed

[v22.x] deps: V8: backport Wasm exception handling correctness fixes #62783

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
9568ca7
deps: V8: cherry-pick 5f1342c20b59
Liedtke Mar 18, 2024
00480c9
deps: V8: cherry-pick b2f3aea23a01
thibaudmichaud Mar 21, 2024
82e371c
deps: V8: cherry-pick c734674e03f9
manoskouk Apr 1, 2024
6ed9e61
deps: V8: cherry-pick 692f3d526a38
sjrd Apr 10, 2024
652fc6e
deps: V8: cherry-pick cf03d55db2a0
thibaudmichaud Apr 10, 2024
f49efcf
deps: V8: cherry-pick b8f91e510e0f
thibaudmichaud Apr 16, 2024
696df7e
deps: V8: backport 910cb91733dc
jakobkummerow Jun 4, 2024
521d704
deps: V8: backport 89dc6eab605c
thibaudmichaud Jun 10, 2024
b8c6560
deps: V8: backport 323942700cfe
thibaudmichaud Oct 2, 2024
ef09254
deps: V8: backport 63b8849d73ae
thibaudmichaud Oct 9, 2024
a3e2702
deps: V8: cherry-pick 8e214ec3ec8c
thibaudmichaud Oct 9, 2024
0374a22
deps: V8: cherry-pick e7ccf0af1bdd
thibaudmichaud Oct 10, 2024
6e965c7
deps: V8: cherry-pick 7cb6188cf913
thibaudmichaud Oct 16, 2024
ffa9627
deps: V8: cherry-pick b96e40d5ac85
backes Oct 16, 2024
746b4c9
deps: V8: backport 9997fc013952
thibaudmichaud Oct 23, 2024
ff4b2c7
deps: V8: backport 1b27e4674f11
thibaudmichaud Feb 10, 2025
37e2c4c
deps: V8: backport 85b390089e51
thibaudmichaud Mar 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
deps: V8: backport 63b8849d73ae 
Original commit message:

    [wasm][exnref] Reject non-nullable exnref in JS import/export

    R=jkummerow@chromium.org

    Change-Id: I0ba2deb1a9671d87e76fea7bfe76df9eee56442a
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5920338
    Commit-Queue: Thibaud Michaud <thibaudm@chromium.org>
    Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#96489}

Refs: v8/v8@63b8849d73ae
  • Loading branch information
@thibaudmichaud @guybedford
thibaudmichaud authored and guybedford committed Apr 17, 2026
commit ef09254d75625345bd0ab9debe4b78a159f5191d
2 changes: 1 addition & 1 deletion common.gypi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.48',
'v8_embedder_string': '-node.49',

##### V8 defaults for Node.js #####

Expand Down
3 changes: 2 additions & 1 deletion deps/v8/src/wasm/wasm-opcodes.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,13 @@ bool IsJSCompatibleSignature(const FunctionSig* sig) {
// Rtts are internal-only. They should never be part of a signature.
DCHECK(!type.is_rtt());
if (type == kWasmS128) return false;
if (type == kWasmExnRef) return false;
if (type.is_object_reference()) {
switch (type.heap_representation_non_shared()) {
case HeapType::kStringViewWtf8:
case HeapType::kStringViewWtf16:
case HeapType::kStringViewIter:
case HeapType::kExn:
case HeapType::kNoExn:
return false;
default:
break;
Expand Down