Skip to content

stream: align Readable.toWeb termination with eos #62394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduh95 merged 12 commits into from
May 19, 2026
Merged

stream: align Readable.toWeb termination with eos #62394

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
01c0fe8
stream: end Readable.toWeb on half-open duplex
ikeyan Mar 20, 2026
9cff872
stream: preserve terminated Readable adapter state
ikeyan Mar 21, 2026
7c9c069
stream: align Readable adapter termination with eos
ikeyan Mar 22, 2026
3d5bfbb
stream: let Readable.toWeb reuse eos immediate path
ikeyan Mar 23, 2026
6434eb7
stream: cover synchronous Readable.toWeb eos path
ikeyan Mar 23, 2026
cacf709
test: cover BYOB Readable.toWeb termination
ikeyan Mar 23, 2026
e01de1c
stream: simplify eos immediate completion path
ikeyan Mar 23, 2026
cbe1987
test: cover finished on aborted request-like stream
ikeyan Mar 23, 2026
bd8ee4b
stream: fix typo
ikeyan Mar 24, 2026
a0fd4b7
test: cover finished on pre-aborted signal
ikeyan Mar 24, 2026
4609cb7
test: use client response for realistic test case
ikeyan Mar 24, 2026
4922bc4
test: cover synchronous finished pre-aborted signal and initial cleanup
ikeyan Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: cover BYOB Readable.toWeb termination
  • Loading branch information
@ikeyan
ikeyan committed Mar 23, 2026
commit cacf709e3de0cb4266989b0f167515885d0edc48
21 changes: 21 additions & 0 deletions test/parallel/test-whatwg-webstreams-adapters-to-readablestream.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,6 +307,27 @@ const {
})().then(common.mustCall());
}

{
const readable = new PassThrough();
const readableStream = newReadableStreamFromStreamReadable(readable, {
type: 'bytes',
});
const reader = readableStream.getReader({ mode: 'byob' });

(async () => {
const readPromise = reader.read(new Uint8Array(8));

readable.end();
await once(readable, 'end');

assert.deepStrictEqual(await readPromise, {
value: new Uint8Array(0),
done: true,
});
await reader.closed;
})().then(common.mustCall());
}

{
const duplex = new Duplex({ readable: false });
duplex.destroy();
Expand Down
Loading