Skip to content

http: fix use-after-free when freeParser is called during llhttp_execute #62095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
Mar 6, 2026
Merged

http: fix use-after-free when freeParser is called during llhttp_execute #62095

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2ea166
http: fix use-after-free when freeParser is called during llhttp_execute
Flarna Mar 3, 2026
2eef7e7
merge markFreed into remove
Flarna Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
merge markFreed into remove
  • Loading branch information
@Flarna
Flarna committed Mar 5, 2026
commit 2eef7e74b912ee12db44b940ca6cb19397b876d0
3 changes: 1 addition & 2 deletions lib/_http_common.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,9 +189,8 @@ function freeParser(parser, req, socket) {
if (parser) {
if (parser._consumed)
parser.unconsume();
parser.markFreed();
cleanParser(parser);
parser.remove();
cleanParser(parser);
if (parsers.free(parser) === false) {
// Make sure the parser's stack has unwound before deleting the
// corresponding C++ object through .close().
Expand Down
10 changes: 2 additions & 8 deletions src/node_http_parser.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -623,17 +623,13 @@ class Parser : public AsyncWrap, public StreamListener {
parser->EmitDestroy();
}

static void MarkFreed(const FunctionCallbackInfo<Value>& args) {
Parser* parser;
ASSIGN_OR_RETURN_UNWRAP(&parser, args.This());
parser->is_being_freed_ = true;
}

// TODO(@anonrig): Add V8 Fast API
static void Remove(const FunctionCallbackInfo<Value>& args) {
Parser* parser;
ASSIGN_OR_RETURN_UNWRAP(&parser, args.This());

parser->is_being_freed_ = true;

if (parser->connectionsList_ != nullptr) {
parser->connectionsList_->Pop(parser);
parser->connectionsList_->PopActive(parser);
Expand Down Expand Up @@ -1343,7 +1339,6 @@ void CreatePerIsolateProperties(IsolateData* isolate_data,
t->Inherit(AsyncWrap::GetConstructorTemplate(isolate_data));
SetProtoMethod(isolate, t, "close", Parser::Close);
SetProtoMethod(isolate, t, "free", Parser::Free);
SetProtoMethod(isolate, t, "markFreed", Parser::MarkFreed);
SetProtoMethod(isolate, t, "remove", Parser::Remove);
SetProtoMethod(isolate, t, "execute", Parser::Execute);
SetProtoMethod(isolate, t, "finish", Parser::Finish);
Expand Down Expand Up @@ -1413,7 +1408,6 @@ void RegisterExternalReferences(ExternalReferenceRegistry* registry) {
registry->Register(Parser::New);
registry->Register(Parser::Close);
registry->Register(Parser::Free);
registry->Register(Parser::MarkFreed);
registry->Register(Parser::Remove);
registry->Register(Parser::Execute);
registry->Register(Parser::Finish);
Expand Down
Loading