Skip to content

stream: fix TransformStream race on cancel with pending write #62040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 4 commits into from
Mar 4, 2026
Merged

stream: fix TransformStream race on cancel with pending write #62040

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2449435
stream: fix TransformStream race on cancel with pending write
marcopiraccini Feb 28, 2026
398e700
linting fixup
marcopiraccini Feb 28, 2026
a84a506
test-fixup, use assert
marcopiraccini Mar 3, 2026
23c602d
test if undefined instead of typeof. use node:test and assert
marcopiraccini Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
linting fixup 
Signed-off-by: marcopiraccini <marco.piraccini@gmail.com>
  • Loading branch information
@marcopiraccini
marcopiraccini committed Feb 28, 2026
commit 398e70014ef69e06e60870985b876c983f956d27
3 changes: 2 additions & 1 deletion test/parallel/test-whatwg-transformstream-cancel-write-race.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@ const { TransformStream } = require('stream/web');
const { setTimeout } = require('timers/promises');

// Test for https://github.com/nodejs/node/issues/62036
// A late write racing with reader.cancel() should not throw an internal "transformAlgorithm is not a function" TypeError.
// A late write racing with reader.cancel() should not throw an
// internal "transformAlgorithm is not a function" TypeError.

async function test() {
Comment thread
MattiasBuelens marked this conversation as resolved.
Outdated
const stream = new TransformStream({
Expand Down
Loading