Skip to content

http: fix keep-alive socket reuse race in requestOnFinish #61710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
martinslota wants to merge 5 commits into from
Closed

http: fix keep-alive socket reuse race in requestOnFinish #61710

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3e4ce18
http: adds a regression test for issue #60001 against an HTTPS server
martinslota Feb 6, 2026
6624e48
http: adds regression test for issue #60001 against an HTTP server
martinslota Feb 6, 2026
5b78e05
http: fixes keep-alive socket reuse race in requestOnFinish
martinslota Feb 6, 2026
620d56c
http: run `make lint-js-fix`
martinslota Feb 9, 2026
52c3851
http: remove unused require in a test file
martinslota Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
http: run make lint-js-fix
  • Loading branch information
@martinslota
martinslota committed Feb 9, 2026
commit 620d56cc251b8dfd620a6b81150cdf67a970c199
2 changes: 1 addition & 1 deletion test/parallel/test-http-expect-continue-reuse-race.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ function sendRequest(port) {
agent,
headers: {
'Content-Length': '0',
Expect: '100-continue',
'Expect': '100-continue',
},
}, common.mustCall((res) => {
assert.strictEqual(res.statusCode, 200);
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-https-expect-continue-reuse-race.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ function sendRequest(port) {
agent,
headers: {
'Content-Length': '0',
Expect: '100-continue',
'Expect': '100-continue',
},
}, common.mustCall((res) => {
assert.strictEqual(res.statusCode, 200);
Expand Down