Skip to content

src: use node- prefix on thread names #61307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sxa wants to merge 3 commits into from
Closed

src: use node- prefix on thread names #61307

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2e48534
src: use node- prefix on thread names
sxa Jan 6, 2026
d340196
src: avoid renaming WorkerThread
sxa Jan 7, 2026
c0fe99d
src: revert some thread names to fit in Linux' 15 char limit
sxa Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
src: revert some thread names to fit in Linux' 15 char limit 
Signed-off-by: Stewart X Addison <sxa@ibm.com>
  • Loading branch information
@sxa
sxa committed Jan 7, 2026
commit c0fe99d357b04f1999e31950849babb0f3347632
2 changes: 1 addition & 1 deletion src/inspector_agent.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ static void StartIoThreadWakeup(int signo, siginfo_t* info, void* ucontext) {
}

inline void* StartIoThreadMain(void* unused) {
uv_thread_setname("node-SignalInspector");
uv_thread_setname("SignalInspector");
for (;;) {
uv_sem_wait(&start_io_thread_semaphore);
Mutex::ScopedLock lock(start_io_thread_async_mutex);
Expand Down
2 changes: 1 addition & 1 deletion src/inspector_io.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ void InspectorIo::ThreadMain(void* io) {
}

void InspectorIo::ThreadMain() {
int thread_name_error = uv_thread_setname("node-InspectorIo");
int thread_name_error = uv_thread_setname("InspectorIo");
if (!thread_name_error) [[unlikely]] {
per_process::Debug(node::DebugCategory::INSPECTOR_SERVER,
"Failed to set thread name for Inspector\n");
Expand Down
2 changes: 1 addition & 1 deletion src/node_platform.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ class WorkerThreadsTaskRunner::DelayedTaskScheduler {

std::unique_ptr<uv_thread_t> Start() {
auto start_thread = [](void* data) {
uv_thread_setname("node-DelayedTaskSchedulerWorker");
uv_thread_setname("DelayedTaskSchedulerWorker");
static_cast<DelayedTaskScheduler*>(data)->Run();
};
std::unique_ptr<uv_thread_t> t { new uv_thread_t() };
Expand Down
4 changes: 2 additions & 2 deletions src/node_watchdog.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ Watchdog::~Watchdog() {


void Watchdog::Run(void* arg) {
uv_thread_setname("node-Watchdog");
uv_thread_setname("Watchdog");
Watchdog* wd = static_cast<Watchdog*>(arg);

// UV_RUN_DEFAULT the loop will be stopped either by the async or the
Expand Down Expand Up @@ -230,7 +230,7 @@ void TraceSigintWatchdog::HandleInterrupt() {

#ifdef __POSIX__
void* SigintWatchdogHelper::RunSigintWatchdog(void* arg) {
uv_thread_setname("node-SigintWatchdog");
uv_thread_setname("SigintWatchdog");
// Inside the helper thread.
bool is_stopping;
do {
Expand Down
2 changes: 1 addition & 1 deletion src/tracing/agent.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ void Agent::Start() {
uv_thread_create(
&thread_,
[](void* arg) {
uv_thread_setname("node-TraceEventWorker");
uv_thread_setname("TraceEventWorker");
Agent* agent = static_cast<Agent*>(arg);
uv_run(&agent->tracing_loop_, UV_RUN_DEFAULT);
},
Expand Down
Loading