Skip to content

esm: ensure watch mode restarts after syntax errors #61232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 6 commits into from
Jan 15, 2026
Merged

esm: ensure watch mode restarts after syntax errors #61232

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
31caef8
esm: ensure watch mode restarts after syntax errors
Xstoudi Jan 1, 2026
0e69c4d
test
Xstoudi Jan 2, 2026
91fddbe
lint
Xstoudi Jan 2, 2026
4b26149
separate test
Xstoudi Jan 4, 2026
d112842
lint
Xstoudi Jan 4, 2026
9c147fa
forgotten code
Xstoudi Jan 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test
  • Loading branch information
@Xstoudi
Xstoudi committed Jan 2, 2026
commit 0e69c4da38bcbdf9b6ed5e1fae9e0e813542a6a6
47 changes: 47 additions & 0 deletions test/sequential/test-watch-mode.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -884,4 +884,51 @@
await done();
}
});

it('should watch changes even when there is syntax errors during esm loading', async () => {
Comment thread
Xstoudi marked this conversation as resolved.
Resolved
// Create initial file with valid code
const initialContent = `console.log('hello, world');`;
const file = createTmpFile(initialContent, '.mjs');

const { done, restart } = runInBackground({
args: ['--watch', file],
completed: 'Completed running',
shouldFail: true,
});

try {
Comment thread
marco-ippolito marked this conversation as resolved.
Resolved
const { stdout, stderr } = await restart();
assert.strictEqual(stderr, '');
assert.deepStrictEqual(stdout, [
'hello, world',
`Completed running ${inspect(file)}. Waiting for file changes before restarting...`,
])

Check failure on line 905 in test/sequential/test-watch-mode.mjs

View workflow job for this annotation

GitHub Actions / lint-js-and-md 

Missing semicolon

// Update file with syntax error
const syntaxErrorContent = `console.log('hello, wor`;
writeFileSync(file, syntaxErrorContent);

// Wait for the failed restart
const { stderr: stderr2, stdout: stdout2 } = await restart();
assert.match(stderr2, /SyntaxError: Invalid or unexpected token/);
assert.deepStrictEqual(stdout2, [
`Restarting ${inspect(file)}`,
`Failed running ${inspect(file)}. Waiting for file changes before restarting...`,
])

Check failure on line 917 in test/sequential/test-watch-mode.mjs

View workflow job for this annotation

GitHub Actions / lint-js-and-md 

Missing semicolon

writeFileSync(file, `console.log('hello again, world');`);

const { stderr: stderr3, stdout: stdout3 } = await restart();

// Verify it recovered and ran successfully
assert.strictEqual(stderr3, '');
assert.deepStrictEqual(stdout3, [
`Restarting ${inspect(file)}`,
'hello again, world',
`Completed running ${inspect(file)}. Waiting for file changes before restarting...`,
]);
} finally {
await done();
}
});
});
Loading