Skip to content

os: freeze signals constant #61038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 4 commits into from
Dec 22, 2025
Merged

os: freeze signals constant #61038

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f304f91
os: freeze signals constant
Xstoudi Dec 13, 2025
c66f71d
os: add test for signals constant immutability
Xstoudi Dec 13, 2025
4b1a36c
os: run linter on test too
Xstoudi Dec 13, 2025
55ff2a1
fix ci
Xstoudi Dec 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
os: add test for signals constant immutability
  • Loading branch information
@Xstoudi
Xstoudi committed Dec 13, 2025
commit c66f71d92de50b3f61c2f8da29c9fe69ea8df3fc
12 changes: 12 additions & 0 deletions test/parallel/test-os-constants-signals.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
'use strict';

const common = require('../common');

Check failure on line 3 in test/parallel/test-os-constants-signals.js

View workflow job for this annotation

GitHub Actions / lint-js-and-md 

'common' is assigned a value but never used
const { test } = require('node:test');
const assert = require('node:assert');
const { constants } = require('node:os');

const { internalBinding } = require('internal/test/binding');

Check failure on line 8 in test/parallel/test-os-constants-signals.js

View workflow job for this annotation

GitHub Actions / lint-js-and-md 

'internalBinding' is assigned a value but never used

test('Verify that signals constant is immutable', () => {
assert.throws(() => constants.signals.FOOBAR = 1337, TypeError);

Check failure on line 11 in test/parallel/test-os-constants-signals.js

View workflow job for this annotation

GitHub Actions / lint-js-and-md 

Expected indentation of 2 spaces but found 4
})

Check failure on line 12 in test/parallel/test-os-constants-signals.js

View workflow job for this annotation

GitHub Actions / lint-js-and-md 

Missing semicolon

Check failure on line 12 in test/parallel/test-os-constants-signals.js

View workflow job for this annotation

GitHub Actions / lint-js-and-md 

Newline required at end of file but not found
Loading