Skip to content

[v24.x][riscv] Fix check failed in bind_to #60962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kxxt wants to merge 2 commits into from
Closed

[v24.x][riscv] Fix check failed in bind_to #60962

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6185344
deps: V8: backport bbaae8e36164
luyahan Jun 10, 2025
0a99a89
deps: V8: cherry-pick 394a8053b59e
luyahan Jun 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
deps: V8: cherry-pick 394a8053b59e 
Original commit message:

    [riscv] Check trampoline before Constant pool in Release mode

    Change-Id: I9645cded9328dabb2c11c7859b998c838b95f97b
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6653368
    Commit-Queue: Ji Qiu <qiuji@iscas.ac.cn>
    Reviewed-by: Ji Qiu <qiuji@iscas.ac.cn>
    Cr-Commit-Position: refs/heads/main@{#100935}

Refs: v8/v8@394a805
  • Loading branch information
@luyahan @kxxt
luyahan authored and kxxt committed Dec 8, 2025
commit 0a99a89aa4e3e7c955289161c3d46ac4369b90c7
2 changes: 1 addition & 1 deletion common.gypi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.38',
'v8_embedder_string': '-node.39',

##### V8 defaults for Node.js #####

Expand Down
5 changes: 2 additions & 3 deletions deps/v8/src/codegen/riscv/macro-assembler-riscv.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4930,10 +4930,9 @@ void MacroAssembler::Jump(Register target, Condition cond, Register rs,
jr(target);
DEBUG_PRINTF("\tCheckTrampolinePool pc_offset:%d %d\n", pc_offset(),
next_buffer_check() - ConstpoolComputesize());
if (!is_trampoline_emitted() && v8_flags.debug_code &&
if (!is_trampoline_emitted() &&
pc_offset() >= (next_buffer_check() - ConstpoolComputesize())) {
// Debug mode will emit more instrs than Release mode.
// so we need to check trampoline pool before Constant pool.
// We need to check trampoline pool before Constant pool.
// Here need to emit trampoline first.
// Jump(ra, al) will block trampoline pool for 1 instr.
nop();
Expand Down
Loading