Skip to content

util: safely inspect getter errors whose message throws #60684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 16 commits into from
Nov 27, 2025
Merged

util: safely inspect getter errors whose message throws #60684

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
6f5e83d
util: safely inspect getter errors whose message throws
yvele Nov 11, 2025
9f82845
fixup! util: add test cases with getters throwing uncommon values
yvele Nov 12, 2025
e56d00a
fixup! util: handle uncommon thrown errors
yvele Nov 12, 2025
ae30086
fixup! util: ESLint exception line styling
yvele Nov 12, 2025
a1aebbf
fixup! util: add test case with getter throwing undefined
yvele Nov 12, 2025
0e7b9ff
fixup! util: implement consistent `inspect(err)`
yvele Nov 12, 2025
70d029d
fixup! util: improve test readability
yvele Nov 12, 2025
3d87bc7
fixup! util: rely in inspect to describe error
yvele Nov 18, 2025
564570d
fixup! util: typo in test comment
yvele Nov 22, 2025
10d997d
fixup! util: handle inspect options
yvele Nov 24, 2025
6ce0656
fixup! util: fix error catch indentation
yvele Nov 24, 2025
1144617
fixup! util: add infinite recursion test case
yvele Nov 24, 2025
ffe75c6
fixup! util: improve test readability with an array
yvele Nov 24, 2025
83db54c
fixup! util: improve recursive test readability
yvele Nov 25, 2025
a683626
fixup! util: add depth 2 test cases
yvele Nov 25, 2025
dd6be92
fixup! util: add comment explaining stackTraceLimit override in test
yvele Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! util: improve test readability
  • Loading branch information
@yvele
yvele committed Nov 25, 2025
commit 70d029dffb7963442b44c7ed6524efa469696281
6 changes: 3 additions & 3 deletions test/parallel/test-util-inspect.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3347,9 +3347,9 @@ assert.strictEqual(
' [length]: 0,\n' +
" [name]: 'Bar',\n" +
' [prototype]: [Circular *1],\n' +
// Heh? I don't know how to override the error stakc to make it predictable
' [Symbol(Symbol.species)]: ' +
"[Getter: <Inspection threw (TypeError: Symbol.prototype.toString requires that 'this' be a Symbol\n" +
' [Symbol(Symbol.species)]: [Getter: <Inspection threw ' +
// Heh? I don't know how to override the error stack to make it predictable
"(TypeError: Symbol.prototype.toString requires that 'this' be a Symbol\n" +
' at Bar.toString (<anonymous>)\n' +
' at formatPrimitive (node:internal/util/inspect:2246:13)\n' +
' at formatProperty (node:internal/util/inspect:2556:29)\n' +
Expand Down