Skip to content

src: move import.meta initializer to native land #60603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joyeecheung wants to merge 3 commits into from
Closed

src: move import.meta initializer to native land #60603

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
713c813
src: move import.meta initializer to native land
joyeecheung Nov 4, 2025
357f474
fixup! src: move import.meta initializer to native land
joyeecheung Nov 6, 2025
5d486b7
benchmark: focus on import.meta intialization in import-meta benchmark
joyeecheung Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
benchmark: focus on import.meta intialization in import-meta benchmark 
Instead of measuring the performance of the entire module
initialization, focus only on the import.meta initialization.
  • Loading branch information
@joyeecheung
joyeecheung committed Nov 7, 2025
commit 5d486b73b5aab3ea523db5cbe771f318f9960d0c
40 changes: 28 additions & 12 deletions benchmark/esm/import-meta.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,28 +10,44 @@ const bench = common.createBenchmark(main, {
'dirname-and-filename',
'dirname',
'filename',
'url',
],
});

const fixtureDir = path.resolve(__filename, '../../fixtures');
const fixtureDirURL = pathToFileURL(fixtureDir);
async function load(array, n, valuesToRead) {
async function load(n, fixtureFileURL) {
const array = [];
for (let i = 0; i < n; i++) {
array[i] = await import(`${fixtureDirURL}/import-meta-${valuesToRead}.mjs?i=${i}`);
array[i] = await import(`${fixtureFileURL}?i=${i}`);
}
return array;
}

function main({ n, valuesToRead }) {
const array = [];
for (let i = 0; i < n; ++i) {
array.push({ dirname: '', filename: '', i: 0 });
}
const fixtureDir = path.resolve(__filename, '../../fixtures');
const fixtureFile = path.join(fixtureDir, `import-meta-${valuesToRead}.mjs`);
const fixtureFileURL = pathToFileURL(fixtureFile);

bench.start();
load(array, n, valuesToRead).then((arr) => {
load(n, fixtureFileURL).then((array) => {
const results = new Array(n);
bench.start();
for (let i = 0; i < n; i++) {
results[i] = array[i].default();
}
bench.end(n);
if (valuesToRead.includes('dirname')) assert.strictEqual(arr[n - 1].dirname, fixtureDir);
if (valuesToRead.includes('filename')) assert.strictEqual(arr[n - 1].filename, path.join(fixtureDir, `import-meta-${valuesToRead}.mjs`));

switch (valuesToRead) {
case 'dirname-and-filename':
assert.deepStrictEqual(results[n - 1], [fixtureDir, fixtureFile]);
break;
case 'dirname':
assert.strictEqual(results[n - 1], fixtureDir);
break;
case 'filename':
assert.strictEqual(results[n - 1], fixtureFile);
break;
case 'url':
assert.strictEqual(results[n - 1], `${fixtureFileURL}?i=${n - 1}`);
break;
}
});
}
3 changes: 1 addition & 2 deletions benchmark/fixtures/import-meta-dirname-and-filename.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
export const dirname = import.meta.dirname;
export const filename = import.meta.filename;
export default () => [ import.meta.dirname, import.meta.filename ];
2 changes: 1 addition & 1 deletion benchmark/fixtures/import-meta-dirname.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
export const dirname = import.meta.dirname;
export default () => import.meta.dirname;
2 changes: 1 addition & 1 deletion benchmark/fixtures/import-meta-filename.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
export const filename = import.meta.filename;
export default () => import.meta.filename;
1 change: 1 addition & 0 deletions benchmark/fixtures/import-meta-url.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export default () => import.meta.url;
Loading