Skip to content

test: spin longer on flaky platforms for test-worker-prof #60492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
Nov 3, 2025
Merged

test: spin longer on flaky platforms for test-worker-prof #60492

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: spin longer on flaky platforms for test-worker-prof 
Try spinning longer to get more ticks on flaky platforms
and reduce flakiness.
  • Loading branch information
@joyeecheung
joyeecheung committed Oct 29, 2025
commit a232240761e551962718065d0ec30cd9a0fa0658
8 changes: 7 additions & 1 deletion test/sequential/test-worker-prof.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,16 @@ if (process.argv[2] === 'child') {
console.log('parent prof file:', parentProf);

const { Worker } = require('worker_threads');
let spinTime = 1500;
if (common.isWindows || common.isMacOS || process.arch === 's390x') {
// Windows and MacOS tend to be flaky in CI, s390x as well.
// Give them more spins.
spinTime = 4500;
}
const w = new Worker(`
const { parentPort, workerData } = require('worker_threads');

const SPIN_MS = 1500;
const SPIN_MS = ${spinTime};
const start = Date.now();
parentPort.on('message', (data) => {
if (Date.now() - start < SPIN_MS) {
Expand Down
Loading