Skip to content
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
deps: use std::map in MSVC STL for EphemeronRememberedSet
PR-URL: #58070
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  • Loading branch information
joyeecheung authored and targos committed Nov 12, 2025
commit 21ca1a90aee2843f3c43aa2da1b326dc899758b9
2 changes: 1 addition & 1 deletion common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.3',
'v8_embedder_string': '-node.4',

##### V8 defaults for Node.js #####

Expand Down
9 changes: 9 additions & 0 deletions deps/v8/src/heap/ephemeron-remembered-set.h
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,11 @@
#ifndef V8_HEAP_EPHEMERON_REMEMBERED_SET_H_
#define V8_HEAP_EPHEMERON_REMEMBERED_SET_H_

#if defined(_MSVC_STL_VERSION)
#include <map>
#else
#include <unordered_map>
#endif
#include <unordered_set>

#include "src/base/platform/mutex.h"
Expand All @@ -32,8 +36,13 @@ class EphemeronRememberedSet final {
kEphemeronTableListSegmentSize>;

using IndicesSet = std::unordered_set<int>;
#if defined(_MSVC_STL_VERSION)
using TableMap = std::map<Tagged<EphemeronHashTable>, IndicesSet,
Object::Comparer>;
#else
using TableMap = std::unordered_map<Tagged<EphemeronHashTable>, IndicesSet,
Object::Hasher>;
#endif

void RecordEphemeronKeyWrite(Tagged<EphemeronHashTable> table,
Address key_slot);
Expand Down