Skip to content

debugger: fix event listener leak in the run command #60464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 3 commits into from
Nov 7, 2025
Merged

debugger: fix event listener leak in the run command #60464

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5ff338f
debugger: fix event listener leak in the run command
joyeecheung Oct 28, 2025
cda1c0e
fixup! debugger: fix event listener leak in the run command
joyeecheung Oct 29, 2025
ccabb52
fixup! fixup! debugger: fix event listener leak in the run command
joyeecheung Nov 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! fixup! debugger: fix event listener leak in the run command
  • Loading branch information
@joyeecheung
joyeecheung committed Nov 4, 2025
commit ccabb5270a815f14c4f982985e82c458c89e1b7a
25 changes: 5 additions & 20 deletions lib/internal/debugger/inspect_client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ const {
const Buffer = require('buffer').Buffer;
const crypto = require('crypto');
const { ERR_DEBUGGER_ERROR } = require('internal/errors').codes;
const { EventEmitter } = require('events');
const { EventEmitter, once } = require('events');
const http = require('http');
const { URL } = require('internal/url');

Expand Down Expand Up @@ -343,25 +343,10 @@ class Client extends EventEmitter {
this.emit('ready');
};

return new Promise((resolve, reject) => {
const tearDown = () => {
this.removeListener('ready', onReady);
this.removeListener('error', onError);
};
const onError = (err) => {
tearDown();
reject(err);
};
const onReady = () => {
tearDown();
resolve();
};
this.on('error', onError);
this.on('ready', onReady);

httpReq.on('upgrade', handshakeListener);
httpReq.end();
});
const onReady = once(this, 'ready');
httpReq.on('upgrade', handshakeListener);
httpReq.end();
return onReady;
}
}

Expand Down
Loading