Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
23468fd
http2: fix allowHttp1+Upgrade, broken by shouldUpgradeCallback
pimterry Sep 20, 2025
fe492c7
process: fix hrtime fast call signatures
Renegade334 Jul 13, 2025
81548ab
wasi: fix WasiFunction fast call signature
Renegade334 Jul 13, 2025
cee3622
timers: fix binding fast call signatures
Renegade334 Jul 13, 2025
78efd1b
benchmark: update num to n in dgram offset-length
brunocroh Sep 1, 2025
af0a8ba
benchmark: adjust dgram offset-length len values
brunocroh Sep 1, 2025
af3a59d
test: verify tracing channel doesn't swallow unhandledRejection
Flarna Sep 24, 2025
4e8d99f
benchmark: update num to n in dgram offset-length
brunocroh Sep 12, 2025
6764ce8
benchmark: update count to n in permission startup
brunocroh Sep 12, 2025
af33e8e
benchmark: remove unused variable from util/priority-queue
brunocroh Sep 12, 2025
c7c597e
src: use RAII for uv_process_options_t
iknoom Sep 20, 2025
54b439f
src: fill `options_args`, `options_env` after vectors are finalized
iknoom Sep 22, 2025
b58df47
test: fix typo of test-benchmark-readline.js
deokjinkim Sep 23, 2025
26394cd
test: expand tls-check-server-identity coverage
diangogav Sep 24, 2025
df72dc9
console,util: improve array inspection performance
BridgeAR Sep 27, 2025
d1fb8a5
src: avoid unnecessary string -> `char*` -> string round trips
addaleax Sep 28, 2025
1289ef8
src: remove unnecessary shadowed functions on Utf8Value & BufferValue
addaleax Sep 28, 2025
764d356
src: remove unnecessary `std::string` error messages
addaleax Sep 28, 2025
c3be122
src: allow `std::string_view` arguments to `SPrintF()` and friends
addaleax Sep 28, 2025
9fae03c
tools: use dependabot cooldown and move tools/doc
RafaelGSS Sep 30, 2025
6e386c0
src: make ToLower/ToUpper input args more flexible
addaleax Sep 28, 2025
987841a
src: avoid unnecessary string allocations in SPrintF impl
addaleax Sep 28, 2025
4206406
test: mark test-web-locks skip on IBM i
sravani1510 Oct 1, 2025
81a3055
process: fix default `env` for `process.execve`
richardlau Oct 1, 2025
609c063
src: remove unused variables from report
iknoom Oct 2, 2025
e4b95a5
test: replace diagnostics_channel stackframe in output snapshots
legendecas Oct 3, 2025
c2dd6ee
process: fix wrong asyncContext under unhandled-rejections=strict
islandryu Oct 4, 2025
ea5cfd9
lib: implement passive listener behavior per spec
Amemome Oct 4, 2025
56abc4a
lib: optimize priority queue
gurgunday Oct 4, 2025
aac90d3
tools: verify signatures when updating nghttp*
aduh95 Oct 5, 2025
b928ea9
test: ensure that the message event is fired
lpinca Oct 5, 2025
40fea57
tools: add message on auto-fixing js lint issues in gh workflow
dario-piotrowicz Oct 5, 2025
ef67d09
http: improve writeEarlyHints by avoiding for-of loop
haramj Oct 6, 2025
2197097
src: remove `AnalyzeTemporaryDtors` option from .clang-tidy
iknoom Sep 25, 2025
76b4cab
src: bring permissions macros in line with general C/C++ standards
addaleax Sep 28, 2025
6ac4ab1
2025-10-28, Version 22.21.1 'Jod' (LTS)
nodejs-github-bot Oct 23, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
benchmark: update count to n in permission startup
PR-URL: #59872
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information
brunocroh authored and aduh95 committed Oct 22, 2025
commit 6764ce8756b0955b4b08c9406b663f6fd2696eb2
12 changes: 6 additions & 6 deletions benchmark/permission/permission-startup.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,12 @@ const bench = common.createBenchmark(main, {
],
prefixPath: ['/tmp'],
nFiles: [10, 100, 1000],
count: [30],
n: [30],
});

function spawnProcess(script, bench, state) {
const cmd = process.execPath || process.argv[0];
while (state.finished < state.count) {
while (state.finished < state.n) {
const child = spawnSync(cmd, script);
if (child.status !== 0) {
console.log('---- STDOUT ----');
Expand All @@ -39,13 +39,13 @@ function spawnProcess(script, bench, state) {
bench.start();
}

if (state.finished === state.count) {
bench.end(state.count);
if (state.finished === state.n) {
bench.end(state.n);
}
}
}

function main({ count, script, nFiles, prefixPath }) {
function main({ n, script, nFiles, prefixPath }) {
script = path.resolve(__dirname, '../../', `${script}.js`);
const optionsWithScript = [
'--permission',
Expand All @@ -54,6 +54,6 @@ function main({ count, script, nFiles, prefixPath }) {
script,
];
const warmup = 3;
const state = { count, finished: -warmup };
const state = { n, finished: -warmup };
spawnProcess(optionsWithScript, bench, state);
}