Skip to content

src: use cached primordials_string #60255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
Oct 19, 2025
Merged

src: use cached primordials_string #60255

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
src: use cached primordials_string
  • Loading branch information
@KimSH39
KimSH39 committed Oct 15, 2025
commit 8f7e297a737a9f40e4897d8e41bfe4ca8afe7d50
3 changes: 1 addition & 2 deletions src/api/environment.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -853,8 +853,7 @@ Maybe<void> InitializePrimordials(Local<Context> context,
if (!GetPerContextExports(context).ToLocal(&exports)) {
return Nothing<void>();
}
Local<String> primordials_string =
FIXED_ONE_BYTE_STRING(isolate, "primordials");
Local<String> primordials_string = isolate_data->primordials_string();
// Ensure that `InitializePrimordials` is called exactly once on a given
// context.
CHECK(!exports->Has(context, primordials_string).FromJust());
Expand Down
Loading