Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
90 commits
Select commit Hold shift + click to select a range
91dda5f
deps: update undici to 6.22.0
mcollina Oct 7, 2025
7e0e86c
deps: upgrade npm to 10.9.4
npm-cli-bot Oct 7, 2025
99ea08d
repl: add isValidParentheses check before wrap input
meixg Oct 7, 2025
2237142
module: link module with a module request record
legendecas Oct 7, 2025
7a91282
src: use simdjson::pad
0hmX Aug 17, 2025
6021c3a
tools: copyedit `build-tarball.yml`
aduh95 Sep 10, 2025
ec5290f
build: do not include custom ESLint rules testing in tarball
aduh95 Sep 8, 2025
b632a1d
tools: skip test-internet workflow for draft PRs
targos Sep 11, 2025
d2a7057
lib,src: refactor assert to load error source from memory
legendecas Sep 2, 2025
12e5535
lib: add source map support for assert messages
legendecas Sep 3, 2025
bb6fd7c
src: ensure `v8::Eternal` is empty before setting it
addaleax Sep 11, 2025
9833dc6
doc: rephrase dynamic import() description
meteorqz6 Sep 12, 2025
24c2249
url: add type checking to urlToHttpOptions()
simon-id Sep 12, 2025
16c4b46
benchmark: calibrate config cluster/echo.js
meteorqz6 Sep 12, 2025
4cc84c9
node-api: make napi_delete_reference use node_api_basic_env
JeetuSuthar Sep 12, 2025
4d748ad
src: remove `std::array` overload of `FIXED_ONE_BYTE_STRING`
addaleax Aug 4, 2025
34dcb7d
src: create strings in `FIXED_ONE_BYTE_STRING` as internalized
addaleax Aug 4, 2025
e790eb6
repl: fix cpu overhead pasting big strings to the REPL
BridgeAR Sep 14, 2025
f2fbcc5
util: fix debuglog.enabled not being present with callback logger
BridgeAR Sep 14, 2025
8fd669c
doc: type improvement of file `http.md`
samuel871211 Sep 14, 2025
f88752d
url: replaced slice with at
Connormiha Sep 14, 2025
a71dd59
benchmark: calibrate config dgram multi-buffer
brunocroh Sep 14, 2025
758271a
http: optimize checkIsHttpToken for short strings
JinhyeokFang Sep 14, 2025
a33ed9b
inspector: ensure adequate memory allocation for `Binary::toBase64`
Renegade334 Sep 14, 2025
0a3a3f7
doc: add security escalation policy
UlisesGascon Sep 15, 2025
28ef564
typings: remove unused imports
meteorqz6 Sep 15, 2025
6d24b88
node-api: added SharedArrayBuffer api
mertcanaltin Sep 16, 2025
ba00875
stream: use new AsyncResource instead of bind
mcollina Sep 16, 2025
26b40ba
src: replace FIXED_ONE_BYTE_STRING with Environment-cached strings
iknoom Sep 17, 2025
36b68db
src: reduce the nearest parent package JSON cache size
michaelsmithxyz Sep 17, 2025
85818db
fs,win: do not add a second trailing slash in readdir
Flarna Sep 17, 2025
c42c120
tools: fix `tools/make-v8.sh` for clang
richardlau Sep 17, 2025
af8b5fa
http: add shouldUpgradeCallback to let servers control HTTP upgrades
pimterry Sep 17, 2025
2bf0a93
meta: add .npmrc with ignore-scripts=true
joyeecheung Sep 17, 2025
e02a562
deps: upgrade openssl sources to openssl-3.5.3
nodejs-github-bot Sep 16, 2025
48aaf98
deps: update archs files for openssl-3.5.3
nodejs-github-bot Sep 16, 2025
09bdcce
diagnostics_channel: fix race condition with diagnostics_channel and GC
Sep 19, 2025
892b425
src: rename private fields to follow naming convention
iknoom Sep 20, 2025
c9cde35
src: simplify is_callable by making it a concept
tniessen Sep 20, 2025
34c686b
lib: update inspect output format for subclasses
miguelmarcondesf Sep 21, 2025
ca1942c
test: testcase demonstrating issue 59541
ericrannaud Sep 7, 2025
312b33a
vm: "afterEvaluate", evaluate() return a promise from the outer context
ericrannaud Sep 10, 2025
5bf21a4
vm: explain how to share promises between contexts w/ afterEvaluate
ericrannaud Sep 19, 2025
3a3220a
dgram: restore buffer optimization in fixBufferList
ri7116 Sep 21, 2025
d6e303d
doc: update V8 fast API guidance
Renegade334 Sep 21, 2025
53cb9f3
build: add the missing macro definitions for OpenHarmony
hqzing Sep 22, 2025
816e1be
zlib: reduce code duplication
jhofstee Sep 22, 2025
badbba2
deps: update googletest to 50b8600
nodejs-github-bot Sep 23, 2025
4808dbd
doc: fix typo in section on microtask order
tniessen Sep 23, 2025
4bc366f
doc: use "WebAssembly" instead of "Web Assembly"
tniessen Sep 24, 2025
8e182e5
src: remove unnecessary `Environment::GetCurrent()` calls
iknoom Sep 11, 2025
aed9fd5
crypto: avoid calls to `promise.catch()`
Renegade334 Sep 9, 2025
f488b2f
crypto: use async functions for non-stub Promise-returning functions
Renegade334 Sep 9, 2025
1f93913
crypto: use `return await` when returning Promises from async functions
Renegade334 Sep 9, 2025
2870a73
doc,crypto: update subtle.generateKey and subtle.importKey
panva Sep 13, 2025
095e7a8
tls: only do off-thread certificate loading on loading tls
joyeecheung Sep 11, 2025
19a7b1e
tls: load bundled and extra certificates off-thread
joyeecheung Sep 11, 2025
e4a4f63
sqlite: fix crash session extension callbacks with workers
louwers Sep 23, 2025
ddbc1aa
deps: upgrade openssl sources to openssl-3.5.4
nodejs-github-bot Oct 1, 2025
28aea13
deps: update archs files for openssl-3.5.4
nodejs-github-bot Oct 1, 2025
37c2d18
deps: update amaro to 1.1.4
pmarchini Sep 29, 2025
04590b8
meta: bump actions/setup-python from 5.6.0 to 6.0.0
dependabot[bot] Oct 5, 2025
0fedbb3
meta: bump ossf/scorecard-action from 2.4.2 to 2.4.3
dependabot[bot] Oct 4, 2025
1f3b9d6
meta: bump actions/cache from 4.2.4 to 4.3.0
dependabot[bot] Oct 4, 2025
7cd2b42
meta: bump step-security/harden-runner from 2.12.2 to 2.13.1
dependabot[bot] Oct 4, 2025
0feca0c
meta: bump actions/setup-node from 4.4.0 to 5.0.0
dependabot[bot] Oct 4, 2025
a0ba688
meta: bump actions/stale from 9.1.0 to 10.0.0
dependabot[bot] Oct 4, 2025
090ba14
meta: bump codecov/codecov-action from 5.5.0 to 5.5.1
dependabot[bot] Oct 3, 2025
c591cca
meta: bump github/codeql-action from 3.30.0 to 3.30.5
dependabot[bot] Oct 3, 2025
20a9e86
meta: move Michael to emeritus
mhdawson Oct 1, 2025
3fca564
doc: add automated migration info to deprecations
AugustinMauroy Oct 6, 2025
ca2dff6
doc: fix typo on child_process.md
nglgzz Oct 6, 2025
d37f67d
doc: remove optional title prefixes
avivkeller Oct 5, 2025
3b3b71e
doc: mark `.env` files support as stable
Hilzu Oct 3, 2025
1ddaab1
doc: mention reverse proxy and include simple example
styfle Sep 4, 2025
b3eeb3b
doc: provide alternative to `url.parse()` using WHATWG URL
styfle Sep 2, 2025
ef005d0
typings: update 'types' binding
Renegade334 Sep 24, 2025
84701ff
src: clear all linked module caches once instantiated
legendecas Jul 29, 2025
e10dc7b
module: allow overriding linked requests for a ModuleWrap
legendecas Aug 22, 2025
6277058
vm: sync-ify SourceTextModule linkage
legendecas Aug 29, 2025
1eadab8
win,tools: add description to signature
martincostello Oct 3, 2025
7067d79
test: mark sea tests flaky on macOS x64
richardlau Sep 30, 2025
686ac49
src: add percentage support to --max-old-space-size
Asaf-Federman Jul 28, 2025
42c5544
src: assert memory calc for max-old-space-size-percentage
Asaf-Federman Aug 18, 2025
660d573
test,doc: skip --max-old-space-size-percentage on 32-bit platforms
Asaf-Federman Oct 9, 2025
bedaaa1
http: support http proxy for fetch under NODE_USE_ENV_PROXY
joyeecheung Mar 20, 2025
ebec3ef
test: move http proxy tests to test/client-proxy
joyeecheung Jul 3, 2025
4210259
http,https: add built-in proxy support in http/https.request and Agent
joyeecheung Jul 1, 2025
1486fed
cli: add --use-env-proxy
joyeecheung Jul 26, 2025
54b94e1
2025-10-20, Version 22.21.0 'Jod' (LTS)
aduh95 Oct 18, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
node-api: added SharedArrayBuffer api
PR-URL: #59071
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
  • Loading branch information
mertcanaltin authored and aduh95 committed Oct 7, 2025
commit 6d24b88fbc21596391bd34745ae8555f94720926
73 changes: 67 additions & 6 deletions doc/api/n-api.md
Original file line number Diff line number Diff line change
Expand Up @@ -3293,6 +3293,10 @@ Specification.
<!-- YAML
added: v8.0.0
napiVersion: 1
changes:
- version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/59071
description: Added support for `SharedArrayBuffer`.
-->

```c
Expand All @@ -3303,21 +3307,20 @@ napi_status napi_get_arraybuffer_info(napi_env env,
```

* `[in] env`: The environment that the API is invoked under.
* `[in] arraybuffer`: `napi_value` representing the `ArrayBuffer` being queried.
* `[out] data`: The underlying data buffer of the `ArrayBuffer`. If byte\_length
* `[in] arraybuffer`: `napi_value` representing the `ArrayBuffer` or `SharedArrayBuffer` being queried.
* `[out] data`: The underlying data buffer of the `ArrayBuffer` or `SharedArrayBuffer`
is `0`, this may be `NULL` or any other pointer value.
* `[out] byte_length`: Length in bytes of the underlying data buffer.

Returns `napi_ok` if the API succeeded.

This API is used to retrieve the underlying data buffer of an `ArrayBuffer` and
its length.
This API is used to retrieve the underlying data buffer of an `ArrayBuffer` or `SharedArrayBuffer` and its length.

_WARNING_: Use caution while using this API. The lifetime of the underlying data
buffer is managed by the `ArrayBuffer` even after it's returned. A
buffer is managed by the `ArrayBuffer` or `SharedArrayBuffer` even after it's returned. A
possible safe way to use this API is in conjunction with
[`napi_create_reference`][], which can be used to guarantee control over the
lifetime of the `ArrayBuffer`. It's also safe to use the returned data buffer
lifetime of the `ArrayBuffer` or `SharedArrayBuffer`. It's also safe to use the returned data buffer
within the same callback as long as there are no calls to other APIs that might
trigger a GC.

Expand Down Expand Up @@ -4272,6 +4275,63 @@ This API represents the invocation of the `ArrayBuffer` `IsDetachedBuffer`
operation as defined in [Section isDetachedBuffer][] of the ECMAScript Language
Specification.

### `node_api_is_sharedarraybuffer`

<!-- YAML
added: REPLACEME
-->

> Stability: 1 - Experimental

```c
napi_status node_api_is_sharedarraybuffer(napi_env env, napi_value value, bool* result)
```

* `[in] env`: The environment that the API is invoked under.
* `[in] value`: The JavaScript value to check.
* `[out] result`: Whether the given `napi_value` represents a `SharedArrayBuffer`.

Returns `napi_ok` if the API succeeded.

This API checks if the Object passed in is a `SharedArrayBuffer`.

### `node_api_create_sharedarraybuffer`

<!-- YAML
added: REPLACEME
-->

> Stability: 1 - Experimental

```c
napi_status node_api_create_sharedarraybuffer(napi_env env,
size_t byte_length,
void** data,
napi_value* result)
```

* `[in] env`: The environment that the API is invoked under.
* `[in] byte_length`: The length in bytes of the shared array buffer to create.
* `[out] data`: Pointer to the underlying byte buffer of the `SharedArrayBuffer`.
`data` can optionally be ignored by passing `NULL`.
* `[out] result`: A `napi_value` representing a JavaScript `SharedArrayBuffer`.

Returns `napi_ok` if the API succeeded.

This API returns a Node-API value corresponding to a JavaScript `SharedArrayBuffer`.
`SharedArrayBuffer`s are used to represent fixed-length binary data buffers that
can be shared across multiple workers.

The `SharedArrayBuffer` allocated will have an underlying byte buffer whose size is
determined by the `byte_length` parameter that's passed in.
The underlying buffer is optionally returned back to the caller in case the
caller wants to directly manipulate the buffer. This buffer can only be
written to directly from native code. To write to this buffer from JavaScript,
a typed array or `DataView` object would need to be created.

JavaScript `SharedArrayBuffer` objects are described in
[Section SharedArrayBuffer objects][] of the ECMAScript Language Specification.

## Working with JavaScript properties

Node-API exposes a set of APIs to get and set properties on JavaScript
Expand Down Expand Up @@ -6785,6 +6845,7 @@ the add-on's file name during loading.
[Section IsArray]: https://tc39.es/ecma262/#sec-isarray
[Section IsStrctEqual]: https://tc39.es/ecma262/#sec-strict-equality-comparison
[Section Promise objects]: https://tc39.es/ecma262/#sec-promise-objects
[Section SharedArrayBuffer objects]: https://tc39.es/ecma262/#sec-sharedarraybuffer-objects
[Section ToBoolean]: https://tc39.es/ecma262/#sec-toboolean
[Section ToNumber]: https://tc39.es/ecma262/#sec-tonumber
[Section ToObject]: https://tc39.es/ecma262/#sec-toobject
Expand Down
8 changes: 8 additions & 0 deletions src/js_native_api.h
Original file line number Diff line number Diff line change
Expand Up @@ -474,6 +474,14 @@ napi_get_dataview_info(napi_env env,
napi_value* arraybuffer,
size_t* byte_offset);

#ifdef NAPI_EXPERIMENTAL
#define NODE_API_EXPERIMENTAL_HAS_SHAREDARRAYBUFFER
NAPI_EXTERN napi_status NAPI_CDECL
node_api_is_sharedarraybuffer(napi_env env, napi_value value, bool* result);
NAPI_EXTERN napi_status NAPI_CDECL node_api_create_sharedarraybuffer(
napi_env env, size_t byte_length, void** data, napi_value* result);
#endif // NAPI_EXPERIMENTAL

// version management
NAPI_EXTERN napi_status NAPI_CDECL napi_get_version(node_api_basic_env env,
uint32_t* result);
Expand Down
61 changes: 54 additions & 7 deletions src/js_native_api_v8.cc
Original file line number Diff line number Diff line change
Expand Up @@ -3075,21 +3075,68 @@ napi_status NAPI_CDECL napi_get_arraybuffer_info(napi_env env,
CHECK_ARG(env, arraybuffer);

v8::Local<v8::Value> value = v8impl::V8LocalValueFromJsValue(arraybuffer);
RETURN_STATUS_IF_FALSE(env, value->IsArrayBuffer(), napi_invalid_arg);

v8::Local<v8::ArrayBuffer> ab = value.As<v8::ArrayBuffer>();
if (value->IsArrayBuffer()) {
v8::Local<v8::ArrayBuffer> ab = value.As<v8::ArrayBuffer>();

if (data != nullptr) {
*data = ab->Data();
}
if (data != nullptr) {
*data = ab->Data();
}

if (byte_length != nullptr) {
*byte_length = ab->ByteLength();
if (byte_length != nullptr) {
*byte_length = ab->ByteLength();
}
} else if (value->IsSharedArrayBuffer()) {
v8::Local<v8::SharedArrayBuffer> sab = value.As<v8::SharedArrayBuffer>();

if (data != nullptr) {
*data = sab->Data();
}

if (byte_length != nullptr) {
*byte_length = sab->ByteLength();
}
} else {
return napi_set_last_error(env, napi_invalid_arg);
}

return napi_clear_last_error(env);
}

napi_status NAPI_CDECL node_api_is_sharedarraybuffer(napi_env env,
napi_value value,
bool* result) {
CHECK_ENV_NOT_IN_GC(env);
CHECK_ARG(env, value);
CHECK_ARG(env, result);

v8::Local<v8::Value> val = v8impl::V8LocalValueFromJsValue(value);
*result = val->IsSharedArrayBuffer();

return napi_clear_last_error(env);
}

napi_status NAPI_CDECL node_api_create_sharedarraybuffer(napi_env env,
size_t byte_length,
void** data,
napi_value* result) {
NAPI_PREAMBLE(env);
CHECK_ARG(env, result);

v8::Isolate* isolate = env->isolate;
v8::Local<v8::SharedArrayBuffer> buffer =
v8::SharedArrayBuffer::New(isolate, byte_length);

// Optionally return a pointer to the buffer's data, to avoid another call to
// retrieve it.
if (data != nullptr) {
*data = buffer->Data();
}

*result = v8impl::JsValueFromV8LocalValue(buffer);
return GET_RETURN_STATUS(env);
}

napi_status NAPI_CDECL napi_is_typedarray(napi_env env,
napi_value value,
bool* result) {
Expand Down
8 changes: 8 additions & 0 deletions test/js-native-api/test_sharedarraybuffer/binding.gyp
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"targets": [
{
"target_name": "test_sharedarraybuffer",
"sources": [ "test_sharedarraybuffer.c" ]
}
]
}
67 changes: 67 additions & 0 deletions test/js-native-api/test_sharedarraybuffer/test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,67 @@
'use strict';

const common = require('../../common');
const assert = require('assert');
const test_sharedarraybuffer = require(`./build/${common.buildType}/test_sharedarraybuffer`);

{
const sab = new SharedArrayBuffer(16);
const ab = new ArrayBuffer(16);
const obj = {};
const arr = [];

assert.strictEqual(test_sharedarraybuffer.TestIsSharedArrayBuffer(sab), true);
assert.strictEqual(test_sharedarraybuffer.TestIsSharedArrayBuffer(ab), false);
assert.strictEqual(test_sharedarraybuffer.TestIsSharedArrayBuffer(obj), false);
assert.strictEqual(test_sharedarraybuffer.TestIsSharedArrayBuffer(arr), false);
assert.strictEqual(test_sharedarraybuffer.TestIsSharedArrayBuffer(null), false);
assert.strictEqual(test_sharedarraybuffer.TestIsSharedArrayBuffer(undefined), false);
}

// Test node_api_create_sharedarraybuffer
{
const sab = test_sharedarraybuffer.TestCreateSharedArrayBuffer(16);
assert(sab instanceof SharedArrayBuffer);
assert.strictEqual(sab.byteLength, 16);
}

// Test node_api_create_get_sharedarraybuffer_info
{
const sab = new SharedArrayBuffer(32);
const byteLength = test_sharedarraybuffer.TestGetSharedArrayBufferInfo(sab);
assert.strictEqual(byteLength, 32);
}

// Test data access
{
const sab = new SharedArrayBuffer(8);
const result = test_sharedarraybuffer.TestSharedArrayBufferData(sab);
assert.strictEqual(result, true);

// Check if data was written correctly
const view = new Uint8Array(sab);
for (let i = 0; i < 8; i++) {
assert.strictEqual(view[i], i % 256);
}
}

// Test data pointer from existing SharedArrayBuffer
{
const sab = new SharedArrayBuffer(16);
const result = test_sharedarraybuffer.TestSharedArrayBufferData(sab);
assert.strictEqual(result, true);
}

// Test zero-length SharedArrayBuffer
{
const sab = test_sharedarraybuffer.TestCreateSharedArrayBuffer(0);
assert(sab instanceof SharedArrayBuffer);
assert.strictEqual(sab.byteLength, 0);
}

// Test invalid arguments
{
assert.throws(() => {
test_sharedarraybuffer.TestGetSharedArrayBufferInfo({});
}, { name: 'Error', message: 'Invalid argument' });
}
Loading