Skip to content

sqlite: allow setting defensive flag #60217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 6 commits into from
Oct 27, 2025
Merged

sqlite: allow setting defensive flag #60217

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b493979
sqlite: allow setting defensive flag
louwers Oct 11, 2025
bafeb0a
test: add test for wrong argument type
louwers Oct 11, 2025
a1ea22d
sqlite: enable defensive mode by default
louwers Oct 11, 2025
55176d3
sqlite: revert "sqlite: enable defensive mode by default"
louwers Oct 12, 2025
a522262
sqlite: add changes YAML
louwers Oct 12, 2025
af87669
doc: fix order changes list
louwers Oct 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
sqlite: enable defensive mode by default
  • Loading branch information
@louwers
louwers committed Oct 11, 2025
commit a1ea22de0c380caeb4ec373732eaf961b156063b
2 changes: 1 addition & 1 deletion src/node_sqlite.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ class DatabaseOpenConfiguration {
bool return_arrays_ = false;
bool allow_bare_named_params_ = true;
bool allow_unknown_named_params_ = false;
bool defensive_ = false;
bool defensive_ = true;
Comment thread
louwers marked this conversation as resolved.
Outdated
};

class DatabaseSync;
Expand Down
24 changes: 12 additions & 12 deletions test/parallel/test-sqlite-config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,30 +20,30 @@ function checkDefensiveMode(db) {
}
}
Comment thread
louwers marked this conversation as resolved.

test('by default, defensive mode is off', (t) => {
test('by default, defensive mode is on', (t) => {
const db = new DatabaseSync(':memory:');
t.assert.strictEqual(checkDefensiveMode(db), false);
t.assert.strictEqual(checkDefensiveMode(db), true);
});

test('when passing { defensive: true } as config, defensive mode is on', (t) => {
test('when passing { defensive: false } as config, defensive mode is off', (t) => {
const db = new DatabaseSync(':memory:', {
defensive: true
defensive: false
});
t.assert.strictEqual(checkDefensiveMode(db), true);
t.assert.strictEqual(checkDefensiveMode(db), false);
});

test('defensive mode on after calling db.enableDefensive(true)', (t) => {
test('defensive mode should be off after calling db.enableDefensive(false)', (t) => {
const db = new DatabaseSync(':memory:');
db.enableDefensive(true);
t.assert.strictEqual(checkDefensiveMode(db), true);
db.enableDefensive(false);
t.assert.strictEqual(checkDefensiveMode(db), false);
});

test('defensive mode should be off after calling db.enableDefensive(false)', (t) => {
test('defensive mode should be on after calling db.enableDefensive(true)', (t) => {
const db = new DatabaseSync(':memory:', {
defensive: true
defensive: false
});
db.enableDefensive(false);
t.assert.strictEqual(checkDefensiveMode(db), false);
db.enableDefensive(true);
t.assert.strictEqual(checkDefensiveMode(db), true);
});

test('throws if options.defensive is provided but is not a boolean', (t) => {
Expand Down
Loading