Skip to content

src,sqlite: replace tolocalchecked with tolocal #60028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
geeksilva97 wants to merge 3 commits into from
Closed

src,sqlite: replace tolocalchecked with tolocal #60028

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d628a61
src,sqlite: replace tolocalchecked with tolocal
geeksilva97 Sep 26, 2025
4f71c07
src: implement addaleax suggestions
geeksilva97 Sep 28, 2025
1490d09
sqlite: improve session filter error handling
geeksilva97 Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
src: implement addaleax suggestions
  • Loading branch information
@geeksilva97
geeksilva97 committed Sep 28, 2025
commit 4f71c07d7f34d97535597574077f88f8fee9e33a
8 changes: 2 additions & 6 deletions src/node_sqlite.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1763,13 +1763,9 @@ void DatabaseSync::ApplyChangeset(const FunctionCallbackInfo<Value>& args) {

Local<Function> filterFunc = filterValue.As<Function>();

context.filterCallback =
[db, env, filterFunc](std::string_view item) -> bool {
context.filterCallback = [&](std::string_view item) -> bool {
Local<Value> argv[1];
if (!String::NewFromUtf8(env->isolate(),
item.data(),
NewStringType::kNormal,
static_cast<int>(item.size()))
if (!ToV8Value(env->context(), item, env->isolate())
.ToLocal(&argv[0])) {
db->SetIgnoreNextSQLiteError(true);
return false;
Expand Down
Loading