Skip to content

test_runner: simplify logic, nix dead reporter code #59700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 4 commits into from
Jan 16, 2026
Merged

test_runner: simplify logic, nix dead reporter code #59700

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d6a40ce
test_runner: nix dead reporter code
vassudanagunta Sep 1, 2025
adada91
test_runner: make logic more straightforward
vassudanagunta Sep 1, 2025
dac69ea
test_runner: nix more dead code
vassudanagunta Sep 1, 2025
44ccad8
test_runner: make more straightforward, nix more dead code
vassudanagunta Sep 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test_runner: make logic more straightforward 
1. formatTestReport: inline the `const error`
2. move the check for `data.details?.error` out of formatError
   to its sole caller, formatTestReport, which makes more sense.
3. collapse the nested ternary expressions in formatTestReport to one.
  • Loading branch information
@vassudanagunta
vassudanagunta committed Sep 1, 2025
commit adada91bfcc8ca09e4a39d6d622aa7c37674078e
4 changes: 1 addition & 3 deletions lib/internal/test_runner/reporter/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ function indent(nesting) {
}

function formatError(error, indent) {
if (!error) return '';
const err = error.code === 'ERR_TEST_FAILURE' ? error.cause : error;
const message = ArrayPrototypeJoin(
RegExpPrototypeSymbolSplit(
Expand All @@ -81,8 +80,7 @@ function formatTestReport(type, data, prefix = '', indent = '', hasChildren = fa
title += ` # ${typeof todo === 'string' && todo.length ? todo : 'TODO'}`;
}

const error = showErrorDetails ? formatError(data.details?.error, indent) : '';
const err = hasChildren ? '' : error;
const err = showErrorDetails && data.details?.error && !hasChildren ? formatError(data.details.error, indent) : '';

if (skip !== undefined) {
color = colors.gray;
Expand Down