Skip to content

esm: sync-ify module translation #59453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
Aug 14, 2025
Merged

esm: sync-ify module translation #59453

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0443ae7
esm: sync-ify module translation
joyeecheung Aug 12, 2025
ac09cb9
fixup! esm: sync-ify module translation
joyeecheung Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! esm: sync-ify module translation 
Co-authored-by: James M Snell <jasnell@gmail.com>
  • Loading branch information
@joyeecheung @jasnell
joyeecheung and jasnell authored Aug 12, 2025
commit ac09cb96aeed5439238c2567748f7c6cd9ced659
2 changes: 1 addition & 1 deletion lib/internal/modules/esm/translators.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -502,7 +502,7 @@ translators.set('wasm', function(url, source) {
let compiled;
try {
compiled = new WebAssembly.Module(source, {
builtins: ['js-string']
builtins: ['js-string'],
});
} catch (err) {
err.message = errPath(url) + ': ' + err.message;
Expand Down